[SPARK-41862][SQL] Fix correctness bug related to DEFAULT values in Orc reader #39370
+19
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fetch latest from master
fetch latest from master
fetch latest from master
fetch latest from master
merge from master
fix the bug fix the bug fix the bug fix the bug
dtenedor
changed the title
Contributor
Author
|
@gengliangwang and @dongjoon-hyun FYI, here is the Orc fix. |
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Thank you, @dtenedor . I'll verify the perf today from my side too.
| test("INSERT rows, ALTER TABLE ADD COLUMNS with DEFAULTs, then SELECT them") { | ||
| case class Config( | ||
| sqlConf: Option[(String, String)], | ||
| insertNullsToStorage: Boolean = true, |
Contributor
Author
I re-ran the Orc benchmark with this PR, here it is for reference: |
gengliangwang
approved these changes
Jan 3, 2023
HyukjinKwon
approved these changes
Jan 4, 2023
Member
|
Merged to master. |
Member
|
Thank you all. +1, late LGTM. |
Contributor
|
late LGTM |
dongjoon-hyun
added a commit
that referenced
this pull request
Jan 4, 2023
### What changes were proposed in this pull request? This PR is a follow-up of #39370 . ### Why are the changes needed? To sync the patch with the recovered perf result. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual review. - Java 8: https://github.com/dongjoon-hyun/spark/actions/runs/3834890434 - Java 11: https://github.com/dongjoon-hyun/spark/actions/runs/3834892478 - Java 17: https://github.com/dongjoon-hyun/spark/actions/runs/3834893844 Closes #39380 from dongjoon-hyun/SPARK-41862. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes a correctness bug related to column DEFAULT values in Orc reader.
Why are the changes needed?
This PR fixes a correctness bug.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
This PR updates a unit test to exercise that the Orc scan functionality is correct.