[SPARK-41034][CONNECT][PYTHON] Connect DataFrame should require a RemoteSparkSession #38541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaliujia
changed the title
amaliujia
changed the title
|
Can one of the admins verify this patch? |
HyukjinKwon
approved these changes
Nov 10, 2022
|
Merged to master. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Nov 10, 2022
### What changes were proposed in this pull request? Fix python mypy ### Why are the changes needed? #38541 breaks the linter ``` starting mypy annotations test... annotations failed mypy checks: python/pyspark/sql/connect/plan.py:683: error: Argument 1 to "plan" of "LogicalPlan" has incompatible type "Optional[RemoteSparkSession]"; expected "RemoteSparkSession" [arg-type] python/pyspark/sql/connect/plan.py:815: error: Argument 1 to "plan" of "LogicalPlan" has incompatible type "Optional[RemoteSparkSession]"; expected "RemoteSparkSession" [arg-type] Found 2 errors in 1 file (checked 369 source files) 1 ``` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? local test Closes #38597 from zhengruifeng/fix_py_lint_1. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
| @@ -91,6 +92,10 @@ def _session_range( | |||
| def _session_sql(cls, query: str) -> "DataFrame": | |||
| return DataFrame.withPlan(SQL(query), cls.connect) # type: ignore | |||
|
|
|||
| @classmethod | |||
| def _with_plan(cls, plan: LogicalPlan) -> "DataFrame": | |||
There was a problem hiding this comment.
Hi, @amaliujia . Unfortunately, this seems to break downstream CIs again by introducing pandas dependency back. In this PR, line 27 seems to be insufficient because _with_plan is a classmethod.
if have_pandas:
...
from pyspark.sql.connect.plan import LogicalPlan
The following error happens.
NameError: name 'LogicalPlan' is not defined
There was a problem hiding this comment.
Hi, @amaliujia . Unfortunately, this seems to break downstream CIs again by introducing
pandasdependency back. In this PR, line 27 seems to be insufficient because_with_planis aclassmethod.if have_pandas: ... from pyspark.sql.connect.plan import LogicalPlanThe following error happens.
NameError: name 'LogicalPlan' is not defined
I think we might be able to replace it with "LogicalPlan" in quotes and use the typing conditional import.
There was a problem hiding this comment.
I made a PR with a different way.
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
…oteSparkSession ### What changes were proposed in this pull request? Connect have marked the session parameter everywhere as `Optional`. This seems to be only useful for testing where test case can ignore the session parameter when it is not applicable. However: 1. There are PySpark DataFrame API that returns SparkSession which is not optional. If Connect keep it as optional then we will have diff on such API. 2. Optional suggests `None` check which seems to not be necessary at many places (or forget to check `None` etc.) This PR proposes to remove the `Optional` on the session from API interface. ### Why are the changes needed? Maintainability ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing UT Closes apache#38541 from amaliujia/dataframe_must_have_a_session. Authored-by: Rui Wang <rui.wang@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
### What changes were proposed in this pull request? Fix python mypy ### Why are the changes needed? apache#38541 breaks the linter ``` starting mypy annotations test... annotations failed mypy checks: python/pyspark/sql/connect/plan.py:683: error: Argument 1 to "plan" of "LogicalPlan" has incompatible type "Optional[RemoteSparkSession]"; expected "RemoteSparkSession" [arg-type] python/pyspark/sql/connect/plan.py:815: error: Argument 1 to "plan" of "LogicalPlan" has incompatible type "Optional[RemoteSparkSession]"; expected "RemoteSparkSession" [arg-type] Found 2 errors in 1 file (checked 369 source files) 1 ``` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? local test Closes apache#38597 from zhengruifeng/fix_py_lint_1. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Connect have marked the session parameter everywhere as
Optional. This seems to be only useful for testing where test case can ignore the session parameter when it is not applicable.However:
Nonecheck which seems to not be necessary at many places (or forget to checkNoneetc.)This PR proposes to remove the
Optionalon the session from API interface.Why are the changes needed?
Maintainability
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing UT