Skip to content

Conversation

@HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR is a retry of #35179. This PR does the same thing - replacing Actions view to Check run view for See test results link.

The main difference with the PR #35179 is that we now keep the Actions run id as is as metadata so this Actions run id can be used to update the status of tests in PRs at Apache Spark:

const params = JSON.parse(cr.output.text)
// Get the workflow run in the forked repository
let run
try {
run = await github.request('GET /repos/{owner}/{repo}/actions/runs/{run_id}', params)
} catch (error) {
console.error(error)
// Run not found. This can happen when the PR author removes GitHub Actions runs or
// disalbes GitHub Actions.
continue
}

Now this PR shouldn't affect update_build_status.yml which was the main reason of a followup and revert.

Why are the changes needed?

For developers to see the test report, and they can easily detect which test is failed.

Does this PR introduce any user-facing change?

No, dev-only

How was this patch tested?

Tested in HyukjinKwon#51.

@HyukjinKwon
Copy link
Member Author

@Yikun do you mind reviewing this when you find some time?

@github-actions github-actions bot added the INFRA label Jan 13, 2022
})
},
details_url: runUrl,
details_url: actions_url,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I think we can even remove this but let me keep it as is for now (https://github.community/t/create-a-check-run-details-url-is-not-being-set/166002). This is currently just a metadata for now.

@Yikun
Copy link
Member

Yikun commented Jan 13, 2022

image

Looks good in my test PR: Yikun#63

I think everything is ok this time. this PR only pluses the request in create PR instead of plus the request in update_build_status job (so it's better than #35192).

@HyukjinKwon
Copy link
Member Author

Thanks! Let me merge this tomorrow so I can monitor other PRs in my day time!

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the recovery.

@HyukjinKwon
Copy link
Member Author

Just to double check, I tested updating workload at https://github.com/HyukjinKwon/spark/runs/4810666021?check_suite_focus=true too.

@HyukjinKwon
Copy link
Member Author

Thanks guys.

Merged to master.

dchvn pushed a commit to dchvn/spark that referenced this pull request Jan 19, 2022
### What changes were proposed in this pull request?

This PR is a retry of apache#35179. This PR does the same thing - replacing Actions view to Check run view for `See test results` link.

The main difference with the PR apache#35179 is that we now keep the Actions run id as is as metadata so this Actions run id can be used to update the status of tests in PRs at Apache Spark:

https://github.com/apache/spark/blob/85efc85f9aa93b3fac9e591c96efa38d4414adf8/.github/workflows/update_build_status.yml#L63-L74

Now this PR shouldn't affect [update_build_status.yml](https://github.com/apache/spark/blob/master/.github/workflows/update_build_status.yml) which was the main reason of a followup and revert.

### Why are the changes needed?

For developers to see the test report, and they can easily detect which test is failed.

### Does this PR introduce _any_ user-facing change?

No, dev-only

### How was this patch tested?

Tested in HyukjinKwon#51.

Closes apache#35193 from HyukjinKwon/SPARK-37879-retry.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
@HyukjinKwon HyukjinKwon deleted the SPARK-37879-retry branch January 15, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants