-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-37879][INFRA] Show test report in GitHub Actions builds from PRs #35193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Yikun do you mind reviewing this when you find some time? |
| }) | ||
| }, | ||
| details_url: runUrl, | ||
| details_url: actions_url, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I think we can even remove this but let me keep it as is for now (https://github.community/t/create-a-check-run-details-url-is-not-being-set/166002). This is currently just a metadata for now.
|
Looks good in my test PR: Yikun#63
I think everything is ok this time. this PR only pluses the request in create PR instead of plus the request in update_build_status job (so it's better than #35192). |
|
Thanks! Let me merge this tomorrow so I can monitor other PRs in my day time! |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the recovery.
|
Just to double check, I tested updating workload at https://github.com/HyukjinKwon/spark/runs/4810666021?check_suite_focus=true too. |
|
Thanks guys. Merged to master. |
### What changes were proposed in this pull request? This PR is a retry of apache#35179. This PR does the same thing - replacing Actions view to Check run view for `See test results` link. The main difference with the PR apache#35179 is that we now keep the Actions run id as is as metadata so this Actions run id can be used to update the status of tests in PRs at Apache Spark: https://github.com/apache/spark/blob/85efc85f9aa93b3fac9e591c96efa38d4414adf8/.github/workflows/update_build_status.yml#L63-L74 Now this PR shouldn't affect [update_build_status.yml](https://github.com/apache/spark/blob/master/.github/workflows/update_build_status.yml) which was the main reason of a followup and revert. ### Why are the changes needed? For developers to see the test report, and they can easily detect which test is failed. ### Does this PR introduce _any_ user-facing change? No, dev-only ### How was this patch tested? Tested in HyukjinKwon#51. Closes apache#35193 from HyukjinKwon/SPARK-37879-retry. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>

What changes were proposed in this pull request?
This PR is a retry of #35179. This PR does the same thing - replacing Actions view to Check run view for
See test resultslink.The main difference with the PR #35179 is that we now keep the Actions run id as is as metadata so this Actions run id can be used to update the status of tests in PRs at Apache Spark:
spark/.github/workflows/update_build_status.yml
Lines 63 to 74 in 85efc85
Now this PR shouldn't affect update_build_status.yml which was the main reason of a followup and revert.
Why are the changes needed?
For developers to see the test report, and they can easily detect which test is failed.
Does this PR introduce any user-facing change?
No, dev-only
How was this patch tested?
Tested in HyukjinKwon#51.