Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-36659][SQL] Promote spark.sql.execution.topKSortFallbackThreshold to a user-facing config #33904

Closed
wants to merge 1 commit into from

Conversation

yaooqinn
Copy link
Member

@yaooqinn yaooqinn commented Sep 3, 2021

What changes were proposed in this pull request?

Promote spark.sql.execution.topKSortFallbackThreshold to a user-facing config

Why are the changes needed?

spark.sql.execution.topKSortFallbackThreshold now is an internal config hidden from users Integer.MAX_VALUE - 15 as its default. In many real-world cases, if the K is very big, there would be performance issues.

It's better to leave this choice to users

Does this PR introduce any user-facing change?

spark.sql.execution.topKSortFallbackThreshold is now user-facing

How was this patch tested?

passing GA

@yaooqinn
Copy link
Member Author

yaooqinn commented Sep 3, 2021

cc @cloud-fan

@github-actions github-actions bot added the SQL label Sep 3, 2021
@SparkQA
Copy link

SparkQA commented Sep 3, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47453/

@SparkQA
Copy link

SparkQA commented Sep 3, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47453/

@SparkQA
Copy link

SparkQA commented Sep 3, 2021

Test build #142953 has finished for PR 33904 at commit 25cadd5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yaooqinn yaooqinn closed this in 7f1ad7b Sep 3, 2021
@yaooqinn
Copy link
Member Author

yaooqinn commented Sep 3, 2021

thanks, merged to master

@yaooqinn yaooqinn deleted the SPARK-36659 branch September 3, 2021 11:12
@dongjoon-hyun
Copy link
Member

+1, late LGTM.
This is only for Apache Spark 3.3, @yaooqinn ?

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Sep 3, 2021

For Apache Kyuubi, I guess we may land this to branch-3.2 before Apache Spark 3.2.0 RC3 starts. In any way, this config was there for a long time already.

cc @gengliangwang

@yaooqinn
Copy link
Member Author

yaooqinn commented Sep 3, 2021

+1, late LGTM.
This is only for Apache Spark 3.3, @yaooqinn ?

@dongjoon-hyun thanks
Oh, I merged it only to 3.3. But I am quite OK to add it into 3.2

dongjoon-hyun pushed a commit that referenced this pull request Sep 3, 2021
…old to a user-facing config

### What changes were proposed in this pull request?

Promote spark.sql.execution.topKSortFallbackThreshold to a user-facing config

### Why are the changes needed?

spark.sql.execution.topKSortFallbackThreshold now is an internal config hidden from users Integer.MAX_VALUE - 15 as its default. In many real-world cases, if the K is very big,  there would be performance issues.

It's better to leave this choice to users

### Does this PR introduce _any_ user-facing change?

 spark.sql.execution.topKSortFallbackThreshold is now user-facing

### How was this patch tested?

passing GA

Closes #33904 from yaooqinn/SPARK-36659.

Authored-by: Kent Yao <yao@apache.org>
Signed-off-by: Kent Yao <yao@apache.org>
(cherry picked from commit 7f1ad7b)
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
@dongjoon-hyun
Copy link
Member

Thank you, @yaooqinn . I backported to branch-3.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants