-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-36659][SQL] Promote spark.sql.execution.topKSortFallbackThreshold to a user-facing config #33904
Conversation
…old to user-faced config
cc @cloud-fan |
Kubernetes integration test starting |
Kubernetes integration test status failure |
Test build #142953 has finished for PR 33904 at commit
|
thanks, merged to master |
+1, late LGTM. |
For Apache Kyuubi, I guess we may land this to branch-3.2 before Apache Spark 3.2.0 RC3 starts. In any way, this config was there for a long time already. |
@dongjoon-hyun thanks |
…old to a user-facing config ### What changes were proposed in this pull request? Promote spark.sql.execution.topKSortFallbackThreshold to a user-facing config ### Why are the changes needed? spark.sql.execution.topKSortFallbackThreshold now is an internal config hidden from users Integer.MAX_VALUE - 15 as its default. In many real-world cases, if the K is very big, there would be performance issues. It's better to leave this choice to users ### Does this PR introduce _any_ user-facing change? spark.sql.execution.topKSortFallbackThreshold is now user-facing ### How was this patch tested? passing GA Closes #33904 from yaooqinn/SPARK-36659. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Kent Yao <yao@apache.org> (cherry picked from commit 7f1ad7b) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Thank you, @yaooqinn . I backported to branch-3.2. |
What changes were proposed in this pull request?
Promote spark.sql.execution.topKSortFallbackThreshold to a user-facing config
Why are the changes needed?
spark.sql.execution.topKSortFallbackThreshold now is an internal config hidden from users Integer.MAX_VALUE - 15 as its default. In many real-world cases, if the K is very big, there would be performance issues.
It's better to leave this choice to users
Does this PR introduce any user-facing change?
spark.sql.execution.topKSortFallbackThreshold is now user-facing
How was this patch tested?
passing GA