Skip to content

[SPARK-35388][INFRA] Allow the PR source branch to include slashes. #32524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ueshin
Copy link
Member

@ueshin ueshin commented May 12, 2021

What changes were proposed in this pull request?

This PR allows the PR source branch to include slashes.

Why are the changes needed?

There are PRs whose source branches include slashes, like issues/SPARK-35119/gha here or #32523.

Before the fix, the PR build fails in Sync the current branch with the latest in Apache Spark phase.
For example, at #32523, the source branch is issues/SPARK-35382/nested_higher_order_functions:

...
fatal: couldn't find remote ref nested_higher_order_functions
Error: Process completed with exit code 128.

(https://github.com/ueshin/apache-spark/runs/2569356241)

Does this PR introduce any user-facing change?

No, this is a dev-only change.

How was this patch tested?

This PR source branch includes slashes and #32525 doesn't.

@github-actions github-actions bot added the INFRA label May 12, 2021
@SparkQA
Copy link

SparkQA commented May 12, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42993/

@SparkQA
Copy link

SparkQA commented May 12, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42993/

@SparkQA
Copy link

SparkQA commented May 12, 2021

Test build #138472 has finished for PR 32524 at commit 3a8c5af.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@ueshin
Copy link
Member Author

ueshin commented May 12, 2021

cc @HyukjinKwon @dongjoon-hyun

@HyukjinKwon
Copy link
Member

Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants