Skip to content

Conversation

@xinrong-meng
Copy link
Member

@xinrong-meng xinrong-meng commented Apr 12, 2021

What changes were proposed in this pull request?

Now that we merged the Koalas main code into the PySpark code base (#32036), we should port the Koalas DataFrame-related unit tests to PySpark.

Why are the changes needed?

Currently, the pandas-on-Spark modules are not fully tested. We should enable the DataFrame-related unit tests first.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Enable DataFrame-related unit tests.

Keyword:SPARK-34849

@SparkQA
Copy link

SparkQA commented Apr 12, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41803/

@SparkQA
Copy link

SparkQA commented Apr 12, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41803/

@xinrong-meng xinrong-meng force-pushed the port.test_dataframe_related branch from 6190e3f to 114610b Compare April 12, 2021 17:36
@SparkQA
Copy link

SparkQA commented Apr 12, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41811/

@SparkQA
Copy link

SparkQA commented Apr 12, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41811/

@SparkQA
Copy link

SparkQA commented Apr 12, 2021

Test build #137225 has finished for PR 32131 at commit 6190e3f.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 12, 2021

Test build #137231 has finished for PR 32131 at commit 114610b.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 13, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41840/

@SparkQA
Copy link

SparkQA commented Apr 13, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41840/

@SparkQA
Copy link

SparkQA commented Apr 13, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41843/

@SparkQA
Copy link

SparkQA commented Apr 13, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41843/

@SparkQA
Copy link

SparkQA commented Apr 13, 2021

Test build #137261 has finished for PR 32131 at commit dc1cd4b.

  • This patch passes all tests.
  • This patch does not merge cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 13, 2021

Test build #137264 has finished for PR 32131 at commit fd77331.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@xinrong-meng xinrong-meng changed the title [WIP][SPARK-35012][PYTHON] Port Koalas DataFrame-related unit tests into PySpark [SPARK-35012][PYTHON] Port Koalas DataFrame-related unit tests into PySpark Apr 13, 2021
@xinrong-meng xinrong-meng marked this pull request as ready for review April 13, 2021 15:33
@xinrong-meng
Copy link
Member Author

CC @ueshin @HyukjinKwon @itholic

Copy link
Member

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ueshin ueshin closed this in 8ebc3fc Apr 13, 2021
@ueshin
Copy link
Member

ueshin commented Apr 13, 2021

Thanks! Merged to master.

@xinrong-meng
Copy link
Member Author

Thanks!

@itholic
Copy link
Contributor

itholic commented Apr 14, 2021

LGTM. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants