[SPARK-32017][PYTHON][FOLLOW-UP] Rename HADOOP_VERSION to PYSPARK_HADOOP_VERSION in pip installation option #31028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ueshin, @dongjoon-hyun, @mengxr, @viirya FYI. Thanks for pointing this out @mengxr. |
cloud-fan
approved these changes
Jan 5, 2021
viirya
reviewed
Jan 5, 2021
viirya
reviewed
Jan 5, 2021
viirya
approved these changes
Jan 5, 2021
|
Thanks @cloud-fan and @viirya ! |
|
Allow me to rush and merge. I am going to cut the RC now. I will monitor the builds and make sure nothing is broken. |
|
Merged to master and branch-3.1. |
HyukjinKwon
added a commit
that referenced
this pull request
Jan 5, 2021
…OOP_VERSION in pip installation option ### What changes were proposed in this pull request? This PR is a followup of #29703. It renames `HADOOP_VERSION` environment variable to `PYSPARK_HADOOP_VERSION` in case `HADOOP_VERSION` is already being used somewhere. Arguably `HADOOP_VERSION` is a pretty common name. I see here and there: - https://www.ibm.com/support/knowledgecenter/SSZUMP_7.2.1/install_grid_sym/understanding_advanced_edition.html - https://cwiki.apache.org/confluence/display/ARROW/HDFS+Filesystem+Support - http://crs4.github.io/pydoop/_pydoop1/installation.html ### Why are the changes needed? To avoid the environment variables is unexpectedly conflicted. ### Does this PR introduce _any_ user-facing change? It renames the environment variable but it's not released yet. ### How was this patch tested? Existing unittests will test. Closes #31028 from HyukjinKwon/SPARK-32017-followup. Authored-by: HyukjinKwon <gurwls223@apache.org> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit 329850c) Signed-off-by: HyukjinKwon <gurwls223@apache.org>
|
Test build #133663 has finished for PR 31028 at commit
|
|
+1, late LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a followup of #29703.
It renames
HADOOP_VERSIONenvironment variable toPYSPARK_HADOOP_VERSIONin caseHADOOP_VERSIONis already being used somewhere. ArguablyHADOOP_VERSIONis a pretty common name. I see here and there:Why are the changes needed?
To avoid the environment variables is unexpectedly conflicted.
Does this PR introduce any user-facing change?
It renames the environment variable but it's not released yet.
How was this patch tested?
Existing unittests will test.