Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-33787][SQL][3.1] Add the purge parameter to dropPartition() of SupportsPartitionManagement #30821

Closed

Conversation

MaxGekk
Copy link
Member

@MaxGekk MaxGekk commented Dec 17, 2020

What changes were proposed in this pull request?

  1. Add the boolean flag purge to dropPartition() in SupportsPartitionManagement and dropPartitions() in SupportsAtomicPartitionManagement.
  2. Propagate the parameter from the logical command to V2 exec node and further to catalog implementations.
  3. Remove the default implementations of dropping partitions from the SupportsPartitionManagement and SupportsAtomicPartitionManagement interfaces.
  4. Update Java docs for dropTable.

Why are the changes needed?

The sql statement ALTER TABLE .. DROP PARTITION allows to specify the PURGE flag but it is ignored by v2 implementation. We should propagate it at least to SupportsPartitionManagement and to SupportsAtomicPartitionManagement, and let to implementations of those interface decide how to support it.

Does this PR introduce any user-facing change?

Should not.

How was this patch tested?

By running new UT:

$ build/sbt -Phive-2.3 -Phive-thriftserver "test:testOnly *AlterTablePartitionV2SQLSuite"

MaxGekk and others added 5 commits December 17, 2020 10:44
…log/SupportsAtomicPartitionManagement.java

Co-authored-by: John Bampton <jbampton@users.noreply.github.com>
…log/SupportsAtomicPartitionManagement.java

Co-authored-by: John Bampton <jbampton@users.noreply.github.com>
@SparkQA
Copy link

SparkQA commented Dec 17, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37545/

@SparkQA
Copy link

SparkQA commented Dec 17, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37545/

@SparkQA
Copy link

SparkQA commented Dec 17, 2020

Test build #132942 has finished for PR 30821 at commit 9c6ef11.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@MaxGekk
Copy link
Member Author

MaxGekk commented Dec 17, 2020

jenkins, retest this, please

@SparkQA
Copy link

SparkQA commented Dec 17, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37556/

@SparkQA
Copy link

SparkQA commented Dec 17, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37556/

@SparkQA
Copy link

SparkQA commented Dec 17, 2020

Test build #132953 has finished for PR 30821 at commit 6cd76f7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants