Skip to content

[SPARK-33810][TESTS] Reenable test cases disabled in SPARK-31732 #30798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-33810][TESTS] Reenable test cases disabled in SPARK-31732 #30798

wants to merge 1 commit into from

Conversation

HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Dec 16, 2020 •
edited
Loading

What changes were proposed in this pull request?

The test failures were due to machine being slow in Jenkins. We switched to Ubuntu 20 if I am not wrong.
Looks like all machines are functioning properly unlike the past, and the tests pass without a problem anymore.

This PR proposes to enable them back.

Why are the changes needed?

To restore test coverage.

Does this PR introduce any user-facing change?

No, dev-only.

How was this patch tested?

Jenkins jobs in this PR show the flakiness.

@HyukjinKwon HyukjinKwon marked this pull request as draft December 16, 2020 07:32
@SparkQA
Copy link

SparkQA commented Dec 16, 2020

Test build #132870 has finished for PR 30798 at commit 75ed2ec.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 16, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37472/

@HyukjinKwon
Copy link
Member Author

retest this please

@SparkQA
Copy link

SparkQA commented Dec 16, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37472/

@HyukjinKwon
Copy link
Member Author

retest this please

@SparkQA
Copy link

SparkQA commented Dec 16, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37481/

@SparkQA
Copy link

SparkQA commented Dec 16, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37481/

@SparkQA
Copy link

SparkQA commented Dec 16, 2020

Test build #132876 has finished for PR 30798 at commit 75ed2ec.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 16, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37482/

@SparkQA
Copy link

SparkQA commented Dec 16, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37482/

@SparkQA
Copy link

SparkQA commented Dec 16, 2020

Test build #132880 has finished for PR 30798 at commit 75ed2ec.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member Author

retest this please

@SparkQA
Copy link

SparkQA commented Dec 16, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37488/

@HyukjinKwon
Copy link
Member Author

retest this please

@SparkQA
Copy link

SparkQA commented Dec 16, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37488/

@SparkQA
Copy link

SparkQA commented Dec 16, 2020

Test build #132886 has finished for PR 30798 at commit 75ed2ec.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member Author

retest this please

@HyukjinKwon HyukjinKwon changed the title [DO-NOT-MERGE][TESTS] Reenable test cases disabeld in SPARK-31732 [SPARK-33810][TESTS] Reenable test cases disabled in SPARK-31732 Dec 16, 2020
@HyukjinKwon HyukjinKwon marked this pull request as ready for review December 16, 2020 14:44
@HyukjinKwon
Copy link
Member Author

cc @cloud-fan, @dongjoon-hyun, @maropu FYI. It's the tests disabled in #28547.

@cloud-fan
Copy link
Contributor

LGTM. Seems they are not flaky any more

@SparkQA
Copy link

SparkQA commented Dec 16, 2020

Test build #132891 has finished for PR 30798 at commit 75ed2ec.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 16, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37496/

@SparkQA
Copy link

SparkQA commented Dec 16, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37496/

dongjoon-hyun
dongjoon-hyun approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thanks, @HyukjinKwon and @cloud-fan .
Merged to master/3.1.

dongjoon-hyun pushed a commit that referenced this pull request Dec 16, 2020
@HyukjinKwon @dongjoon-hyun
[SPARK-33810][TESTS] Reenable test cases disabled in SPARK-31732
fea2a8d 
### What changes were proposed in this pull request?

The test failures were due to machine being slow in Jenkins. We switched to Ubuntu 20 if I am not wrong.
Looks like all machines are functioning properly unlike the past, and the tests pass without a problem anymore.

This PR proposes to enable them back.

### Why are the changes needed?

To restore test coverage.

### Does this PR introduce _any_ user-facing change?

No, dev-only.

### How was this patch tested?

Jenkins jobs in this PR show the flakiness.

Closes #30798 from HyukjinKwon/do-not-merge-test.

Authored-by: HyukjinKwon <gurwls223@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 3d03234)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@SparkQA
Copy link

SparkQA commented Dec 16, 2020

Test build #132894 has finished for PR 30798 at commit 75ed2ec.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member Author

Thank you @cloud-fan and @dongjoon-hyun!

@HyukjinKwon HyukjinKwon deleted the do-not-merge-test branch January 4, 2022 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongjoon-hyun dongjoon-hyun dongjoon-hyun approved these changes

Assignees
No one assigned
Labels
DSTREAM SQL STRUCTURED STREAMING
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HyukjinKwon @SparkQA @cloud-fan @dongjoon-hyun