[SPARK-32434][CORE][FOLLOW-UP] Fix load-spark-env.cmd to be able to run in Windows properly #29254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @dongjoon-hyun, @srowen and @warrenzhu25 |
|
Test build #126630 has finished for PR 29254 at commit
|
Member
Author
|
Thanks, @srowen. Merged to master. |
Member
Author
|
Okay.. now all tests should be fixed now in all CIs... |
Member
|
Oh. Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is basically a followup of SPARK-26132 and SPARK-32434. You can't define an environment variable within an-if to use it within the block. See also https://superuser.com/questions/78496/variables-in-batch-file-not-being-set-when-inside-if
Why are the changes needed?
For Windows users to use Spark and fix the build in AppVeyor.
Does this PR introduce any user-facing change?
No, it's only in unreleased branches.
How was this patch tested?
Manually tested on a local Windows machine, and AppVeyor build at HyukjinKwon#13. See https://ci.appveyor.com/project/HyukjinKwon/spark/builds/34316409