[SPARK-32231][R][INFRA] Use Hadoop 3.2 winutils in AppVeyor build #29042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @dongjoon-hyun FYI |
|
Thank you, @HyukjinKwon ! Let's see. |
|
cc @steveloughran , too. |
|
Test build #125378 has finished for PR 29042 at commit
|
|
4 failures in |
|
Hi, @steveloughran . Sorry, but do you know if there is a known issue about Hadoop 3.x on Windows? Does Hadoop support Windows still? Or, is it dropped? |
dongjoon-hyun
added a commit
that referenced
this pull request
Jul 8, 2020
### What changes were proposed in this pull request? This PR aims to disable SBT `unidoc` generation testing in Jenkins environment because it's flaky in Jenkins environment and not used for the official documentation generation. Also, GitHub Action has the correct test coverage for the official documentation generation. - #28848 (comment) (amp-jenkins-worker-06) - #28926 (comment) (amp-jenkins-worker-06) - #28969 (comment) (amp-jenkins-worker-06) - #28975 (comment) (amp-jenkins-worker-05) - #28986 (comment) (amp-jenkins-worker-05) - #28992 (comment) (amp-jenkins-worker-06) - #28993 (comment) (amp-jenkins-worker-05) - #28999 (comment) (amp-jenkins-worker-04) - #29010 (comment) (amp-jenkins-worker-03) - #29013 (comment) (amp-jenkins-worker-04) - #29016 (comment) (amp-jenkins-worker-05) - #29025 (comment) (amp-jenkins-worker-04) - #29042 (comment) (amp-jenkins-worker-03) ### Why are the changes needed? Apache Spark `release-build.sh` generates the official document by using the following command. - https://github.com/apache/spark/blob/master/dev/create-release/release-build.sh#L341 ```bash PRODUCTION=1 RELEASE_VERSION="$SPARK_VERSION" jekyll build ``` And, this is executed by the following `unidoc` command for Scala/Java API doc. - https://github.com/apache/spark/blob/master/docs/_plugins/copy_api_dirs.rb#L30 ```ruby system("build/sbt -Pkinesis-asl clean compile unidoc") || raise("Unidoc generation failed") ``` However, the PR builder disabled `Jekyll build` and instead has a different test coverage. ```python # determine if docs were changed and if we're inside the amplab environment # note - the below commented out until *all* Jenkins workers can get `jekyll` installed # if "DOCS" in changed_modules and test_env == "amplab_jenkins": # build_spark_documentation() ``` ``` Building Unidoc API Documentation ======================================================================== [info] Building Spark unidoc using SBT with these arguments: -Phadoop-3.2 -Phive-2.3 -Pspark-ganglia-lgpl -Pkubernetes -Pmesos -Phadoop-cloud -Phive -Phive-thriftserver -Pkinesis-asl -Pyarn unidoc ``` ### Does this PR introduce _any_ user-facing change? No. (This is used only for testing and not used in the official doc generation.) ### How was this patch tested? Pass the Jenkins without doc generation invocation. Closes #29017 from dongjoon-hyun/SPARK-DOC-GEN. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
For this PR, I'm testing on Windows. I'll make a PR to you, @HyukjinKwon . |
|
Hi, @HyukjinKwon . I made a PR to you. Could you review and merge that?
|
Use Hadoop 3.2
|
Awesome! |
dongjoon-hyun
changed the title
dongjoon-hyun
changed the title
dongjoon-hyun
approved these changes
Jul 9, 2020
|
Merged to master. Thanks, @dongjoon-hyun. |
|
Test build #125440 has finished for PR 29042 at commit
|
dongjoon-hyun
pushed a commit
that referenced
this pull request
Nov 14, 2023
### What changes were proposed in this pull request? The pr aims to use Hadoop `3.3.5` winutils in AppVeyor build. ### Why are the changes needed? The last update occurred 3 years ago, #29042 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass `AppVeyor` test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #43777 from panbingkun/appveyor_hadoop. Authored-by: panbingkun <pbk1982@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to use Hadoop 3 winutils to make AppVeyor builds pass. Currently it's being failed as below
https://ci.appveyor.com/project/ApacheSoftwareFoundation/spark/builds/33976604
Why are the changes needed?
To recover the build in AppVeyor.
Does this PR introduce any user-facing change?
No, dev-only.
How was this patch tested?
AppVeyor build will test it out.