[SPARK-32209][SQL] Re-use GetTimestamp in ParseToDate #28999
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #124922 has finished for PR 28999 at commit
|
HyukjinKwon
approved these changes
Jul 6, 2020
|
retest this please |
|
Test build #124995 has finished for PR 28999 at commit
|
|
retest this please |
maropu
approved these changes
Jul 6, 2020
|
Test build #125014 has finished for PR 28999 at commit
|
|
retest this please |
|
Test build #125021 has finished for PR 28999 at commit
|
|
jenkins, retest this, please |
|
Test build #125046 has finished for PR 28999 at commit
|
|
jenkins, retest this, please |
|
Test build #125129 has started for PR 28999 at commit |
| @@ -1450,8 +1450,7 @@ case class ParseToDate(left: Expression, format: Option[Expression], child: Expr | |||
| extends RuntimeReplaceable { | |||
|
|
|||
| def this(left: Expression, format: Expression) { | |||
| this(left, Option(format), | |||
| Cast(SecondsToTimestamp(UnixTimestamp(left, format)), DateType)) | |||
There was a problem hiding this comment.
Hi, @MaxGekk . If you don't mind, please make a JIRA issue for this. That will give us a traceability for this.
There was a problem hiding this comment.
Yeah, I was thinking about it too. Maybe it's best to file a JIRA
|
jenkins, retest this, please |
|
Test build #125180 has finished for PR 28999 at commit
|
|
retest this please |
MaxGekk
changed the title
|
Test build #125192 has finished for PR 28999 at commit
|
dongjoon-hyun
approved these changes
Jul 7, 2020
dongjoon-hyun
added a commit
that referenced
this pull request
Jul 8, 2020
### What changes were proposed in this pull request? This PR aims to disable SBT `unidoc` generation testing in Jenkins environment because it's flaky in Jenkins environment and not used for the official documentation generation. Also, GitHub Action has the correct test coverage for the official documentation generation. - #28848 (comment) (amp-jenkins-worker-06) - #28926 (comment) (amp-jenkins-worker-06) - #28969 (comment) (amp-jenkins-worker-06) - #28975 (comment) (amp-jenkins-worker-05) - #28986 (comment) (amp-jenkins-worker-05) - #28992 (comment) (amp-jenkins-worker-06) - #28993 (comment) (amp-jenkins-worker-05) - #28999 (comment) (amp-jenkins-worker-04) - #29010 (comment) (amp-jenkins-worker-03) - #29013 (comment) (amp-jenkins-worker-04) - #29016 (comment) (amp-jenkins-worker-05) - #29025 (comment) (amp-jenkins-worker-04) - #29042 (comment) (amp-jenkins-worker-03) ### Why are the changes needed? Apache Spark `release-build.sh` generates the official document by using the following command. - https://github.com/apache/spark/blob/master/dev/create-release/release-build.sh#L341 ```bash PRODUCTION=1 RELEASE_VERSION="$SPARK_VERSION" jekyll build ``` And, this is executed by the following `unidoc` command for Scala/Java API doc. - https://github.com/apache/spark/blob/master/docs/_plugins/copy_api_dirs.rb#L30 ```ruby system("build/sbt -Pkinesis-asl clean compile unidoc") || raise("Unidoc generation failed") ``` However, the PR builder disabled `Jekyll build` and instead has a different test coverage. ```python # determine if docs were changed and if we're inside the amplab environment # note - the below commented out until *all* Jenkins workers can get `jekyll` installed # if "DOCS" in changed_modules and test_env == "amplab_jenkins": # build_spark_documentation() ``` ``` Building Unidoc API Documentation ======================================================================== [info] Building Spark unidoc using SBT with these arguments: -Phadoop-3.2 -Phive-2.3 -Pspark-ganglia-lgpl -Pkubernetes -Pmesos -Phadoop-cloud -Phive -Phive-thriftserver -Pkinesis-asl -Pyarn unidoc ``` ### Does this PR introduce _any_ user-facing change? No. (This is used only for testing and not used in the official doc generation.) ### How was this patch tested? Pass the Jenkins without doc generation invocation. Closes #29017 from dongjoon-hyun/SPARK-DOC-GEN. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replace the combination of expressions
SecondsToTimestampandUnixTimestampbyGetTimestampinParseToDate.Why are the changes needed?
Eliminate unnecessary parsing overhead in: string -> timestamp -> long (seconds) -> timestamp -> date. After the changes, the chain will be: string -> timestamp -> date.
Does this PR introduce any user-facing change?
No
How was this patch tested?
By existing test suites such as
DateFunctionsSuite.