Skip to content

bash can't die #2898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

bash can't die #2898

wants to merge 1 commit into from

Conversation

jey
Copy link
Contributor

@jey jey commented Oct 23, 2014

This PR fixes the bug that sbt/sbt enters an infinite loop when a required argument is omitted:

jey@kallisti:~/proj/spark$ sbt/sbt -mem 2>&1 | head -n 10
/home/jey/proj/spark/sbt/sbt-launch-lib.bash: line 127: die: command not found
/home/jey/proj/spark/sbt/sbt-launch-lib.bash: line 127: die: command not found
/home/jey/proj/spark/sbt/sbt-launch-lib.bash: line 127: die: command not found
/home/jey/proj/spark/sbt/sbt-launch-lib.bash: line 127: die: command not found
/home/jey/proj/spark/sbt/sbt-launch-lib.bash: line 127: die: command not found
/home/jey/proj/spark/sbt/sbt-launch-lib.bash: line 127: die: command not found
/home/jey/proj/spark/sbt/sbt-launch-lib.bash: line 127: die: command not found
/home/jey/proj/spark/sbt/sbt-launch-lib.bash: line 127: die: command not found
/home/jey/proj/spark/sbt/sbt-launch-lib.bash: line 127: die: command not found
/home/jey/proj/spark/sbt/sbt-launch-lib.bash: line 127: die: command not found
[...]

@SparkQA
Copy link

SparkQA commented Oct 23, 2014

QA tests have started for PR 2898 at commit 55cfb61.

  • This patch merges cleanly.

@sarutak
Copy link
Member

sarutak commented Oct 23, 2014

Hi @jey this issue is in master branch too. Can you also fix that?

@SparkQA
Copy link

SparkQA commented Oct 23, 2014

QA tests have finished for PR 2898 at commit 55cfb61.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22048/
Test PASSed.

@jey
Copy link
Contributor Author

jey commented Oct 23, 2014

Hi @sarutak -- Yes, this issue does exist on master too. What's the recommended procedure here? I assumed it would just be rebased or cherry-picked onto master as part of the merge, but I'm not very familiar with the current merge protocols used by Spark. Thanks!

@pwendell
Copy link
Contributor

Hey @jey our preference is actually that you submit a pull request against master and then we backport it on our own. We have some tooling that makes this easy for us. Do you mind re-opening this agains master?

@srowen
Copy link
Member

srowen commented Oct 24, 2014

(You should also make a JIRA when you change this PR to be against master)

@pwendell
Copy link
Contributor

I'd like to close this issue for now - but @jey we'd love a patch for this against master. it does appear broken!

@sarutak sarutak mentioned this pull request Nov 10, 2014
Closed
@sarutak
Copy link
Member

sarutak commented Nov 10, 2014

@pwendell I've cherry-picked jey's change and open new PR #3182 .

@asfgit asfgit closed this in 227488d Nov 10, 2014
asfgit pushed a commit that referenced this pull request Nov 10, 2014
@jey @pwendell
[SPARK-4312] bash doesn't have "die"
c5db8e2 
sbt-launch-lib.bash includes `die` command but it's not valid command for Linux, MacOS X or Windows.

Closes #2898

Author: Jey Kottalam <jey@kottalam.net>

Closes #3182 from sarutak/SPARK-4312 and squashes the following commits:

24c6677 [Jey Kottalam] bash doesn't have "die"
asfgit pushed a commit that referenced this pull request Nov 10, 2014
@jey @pwendell
[SPARK-4312] bash doesn't have "die"
7917f27 
sbt-launch-lib.bash includes `die` command but it's not valid command for Linux, MacOS X or Windows.

Closes #2898

Author: Jey Kottalam <jey@kottalam.net>

Closes #3182 from sarutak/SPARK-4312 and squashes the following commits:

24c6677 [Jey Kottalam] bash doesn't have "die"

(cherry picked from commit c5db8e2)
Signed-off-by: Patrick Wendell <pwendell@gmail.com>
@jey
Copy link
Contributor Author

jey commented Nov 11, 2014

Thanks @sarutak!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jey @SparkQA @sarutak @AmplabJenkins @pwendell @srowen