Skip to content

[SPARK-31732][TESTS] Disable some flaky tests temporarily #28547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

cloud-fan
Copy link
Contributor

What changes were proposed in this pull request?

It's quite annoying to be blocked by flaky tests in several PRs. This PR disables them. The tests come from 3 PRs I'm recently watching:
#28526
#28463
#28517

Why are the changes needed?

To make PR builder more stable

Does this PR introduce any user-facing change?

no

How was this patch tested?

N/A

@cloud-fan
Copy link
Contributor Author

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented May 15, 2020

Hi, @cloud-fan . So, you are targeting this PR only in master/3.0. Did I understand correctly?

BTW, the most annoying failures came from amp-jenkins-worker-05's corrupted local Maven repository. Hopefully, we can clean up that machine today.

@dongjoon-hyun
Copy link
Member

Do you know how frequently it fail? In master Jenkins build, the following failures occur, too.

  • org.apache.spark.scheduler.BarrierTaskContextSuite.global sync by barrier() call
  • org.apache.spark.sql.kafka010.KafkaMicroBatchV1SourceSuite.subscribing topic by pattern with topic deletions

@SparkQA
Copy link

SparkQA commented May 15, 2020

Test build #122684 has finished for PR 28547 at commit cd12026.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

In another PR (#28509 (comment)), BarrierTaskContextSuite.support multiple barrier() call within a single task.

org.apache.spark.scheduler.BarrierTaskContextSuite.support multiple barrier() call within a single task
sbt.ForkMain$ForkError: org.scalatest.exceptions.TestFailedException: 1031 was not less than or equal to 1000
	at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:530)

@HyukjinKwon
Copy link
Member

@dongjoon-hyun, actually some of them are not related to the corrupt local repository. This was in amp-jenkins-worker-03
https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/5029/.
Looks the corrupt repo was cleaned at amp-jenkins-worker-05 assuming the dependeny tests pass at https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/5039/ (?).

I am retriggering the builds for now. Let's disable them and run the RC if they are still frequently failed.

@cloud-fan
Copy link
Contributor Author

@dongjoon-hyun I'll disable these tests as well, please let me know if you see more.

@dongjoon-hyun
Copy link
Member

Thanks. @cloud-fan . I'm +1 for disabling the above, too.

Yes, @HyukjinKwon . The above are really flaky tests. What I meant was amp-jenkins-worker-05 failure was independent annoying stuff since there is no way to investigate more.

@HyukjinKwon
Copy link
Member

retest this please

@cloud-fan cloud-fan changed the title disable some flaky tests [SPARK-31732][TEST] disable some flaky tests May 16, 2020
@HyukjinKwon HyukjinKwon changed the title [SPARK-31732][TEST] disable some flaky tests [SPARK-31732][TESTS] Disable some flaky tests temporarily May 16, 2020
Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SparkQA
Copy link

SparkQA commented May 16, 2020

Test build #122710 has finished for PR 28547 at commit cd12026.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 16, 2020

Test build #122718 has finished for PR 28547 at commit 01aeeba.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

retest this please

@SparkQA
Copy link

SparkQA commented May 16, 2020

Test build #122722 has finished for PR 28547 at commit 01aeeba.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you all.
Merged to master/3.0.

dongjoon-hyun pushed a commit that referenced this pull request May 16, 2020
### What changes were proposed in this pull request?

It's quite annoying to be blocked by flaky tests in several PRs. This PR disables them. The tests come from 3 PRs I'm recently watching:
#28526
#28463
#28517

### Why are the changes needed?

To make PR builder more stable

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

N/A

Closes #28547 from cloud-fan/test.

Authored-by: Wenchen Fan <wenchen@databricks.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 2012d58)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@dongjoon-hyun
Copy link
Member

cc @rxin since he is a release manager of 3.0.0.
(Also, cc @gatorsmile )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants