-
Notifications
You must be signed in to change notification settings - Fork 28.7k
[SPARK-30345][SQL] Fix intermittent test failure (ConnectException) on ThriftServerQueryTestSuite/ThriftServerWithSparkContextSuite #27001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
88 changes: 88 additions & 0 deletions
88
...riftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/SharedThriftServer.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.sql.hive.thriftserver | ||
|
|
||
| import java.sql.{DriverManager, Statement} | ||
|
|
||
| import scala.concurrent.duration._ | ||
| import scala.util.{Random, Try} | ||
|
|
||
| import org.apache.hadoop.hive.conf.HiveConf.ConfVars | ||
|
|
||
| import org.apache.spark.sql.QueryTest | ||
| import org.apache.spark.sql.test.SharedSparkSession | ||
|
|
||
| trait SharedThriftServer extends SharedSparkSession { | ||
|
|
||
| private var hiveServer2: HiveThriftServer2 = _ | ||
|
|
||
| override def beforeAll(): Unit = { | ||
| super.beforeAll() | ||
| // Chooses a random port between 10000 and 19999 | ||
| var listeningPort = 10000 + Random.nextInt(10000) | ||
|
|
||
| // Retries up to 3 times with different port numbers if the server fails to start | ||
| (1 to 3).foldLeft(Try(startThriftServer(listeningPort, 0))) { case (started, attempt) => | ||
| started.orElse { | ||
| listeningPort += 1 | ||
| Try(startThriftServer(listeningPort, attempt)) | ||
| } | ||
| }.recover { | ||
| case cause: Throwable => | ||
| throw cause | ||
| }.get | ||
| logInfo("HiveThriftServer2 started successfully") | ||
| } | ||
|
|
||
| override def afterAll(): Unit = { | ||
| try { | ||
| hiveServer2.stop() | ||
| } finally { | ||
| super.afterAll() | ||
| } | ||
| } | ||
|
|
||
| protected def withJdbcStatement(fs: (Statement => Unit)*): Unit = { | ||
| val user = System.getProperty("user.name") | ||
|
|
||
| val serverPort = hiveServer2.getHiveConf.get(ConfVars.HIVE_SERVER2_THRIFT_PORT.varname) | ||
| val connections = | ||
| fs.map { _ => DriverManager.getConnection(s"jdbc:hive2://localhost:$serverPort", user, "") } | ||
| val statements = connections.map(_.createStatement()) | ||
|
|
||
| try { | ||
| statements.zip(fs).foreach { case (s, f) => f(s) } | ||
| } finally { | ||
| statements.foreach(_.close()) | ||
| connections.foreach(_.close()) | ||
| } | ||
| } | ||
|
|
||
| private def startThriftServer(port: Int, attempt: Int): Unit = { | ||
| logInfo(s"Trying to start HiveThriftServer2: port=$port, attempt=$attempt") | ||
| val sqlContext = spark.newSession().sqlContext | ||
| sqlContext.setConf(ConfVars.HIVE_SERVER2_THRIFT_PORT.varname, port.toString) | ||
| hiveServer2 = HiveThriftServer2.startWithContext(sqlContext) | ||
|
|
||
| // Wait for thrift server to be ready to serve the query, via executing simple query | ||
| // till the query succeeds. See SPARK-30345 for more details. | ||
| eventually(timeout(30.seconds), interval(1.seconds)) { | ||
| withJdbcStatement { _.execute("SELECT 1") } | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you leave some comments here?