[SPARK-26811][SQL][followup] fix some documentation #24285
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @rdblue |
Contributor
|
+1 |
|
Test build #104252 has finished for PR 24285 at commit
|
srowen
approved these changes
Apr 3, 2019
|
Test build #4682 has finished for PR 24285 at commit
|
Contributor
Author
|
thanks, merging to master! |
mccheah
pushed a commit
to palantir/spark
that referenced
this pull request
May 24, 2019
## What changes were proposed in this pull request? It's a followup of apache#24012 , to fix 2 documentation: 1. `SupportsRead` and `SupportsWrite` are not internal anymore. They are public interfaces now. 2. `Scan` should link the `BATCH_READ` instead of hardcoding it. ## How was this patch tested? N/A Closes apache#24285 from cloud-fan/doc. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
mccheah
pushed a commit
to palantir/spark
that referenced
this pull request
May 24, 2019
## What changes were proposed in this pull request? while working on apache#24129, I realized that I missed some document fixes in apache#24285. This PR covers all of them. ## How was this patch tested? N/A Author: Wenchen Fan <wenchen@databricks.com> Closes apache#24295 from cloud-fan/doc.
mccheah
pushed a commit
to palantir/spark
that referenced
this pull request
Jun 6, 2019
## What changes were proposed in this pull request? It's a followup of apache#24012 , to fix 2 documentation: 1. `SupportsRead` and `SupportsWrite` are not internal anymore. They are public interfaces now. 2. `Scan` should link the `BATCH_READ` instead of hardcoding it. ## How was this patch tested? N/A Closes apache#24285 from cloud-fan/doc. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
It's a followup of #24012 , to fix 2 documentation:
SupportsReadandSupportsWriteare not internal anymore. They are public interfaces now.Scanshould link theBATCH_READinstead of hardcoding it.How was this patch tested?
N/A