Skip to content

[HOTFIX] Fix compilation errors in branch-1.1 #2372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

andrewor14
Copy link
Contributor

This was introduced in 2ffc798.

@andrewor14
Copy link
Contributor Author

test this please

@SparkQA
Copy link

SparkQA commented Sep 12, 2014

QA tests have started for PR 2372 at commit 7066472.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 12, 2014

QA tests have finished for PR 2372 at commit 7066472.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor Author

Weird, this compiles locally... it seems that we're pulling changes from #2020, which was only merged into master.

@JoshRosen
Copy link
Contributor

According to Jenkins, this is the commit that was tested: 8f021acbd81fcf5826fe1a92639e101063e075dd. This corresponds to a commit that was auto-generated by GitHub when testing mergeability.

@andrewor14
Copy link
Contributor Author

I actually reverted #2363 completely for branch-1.1. Looks like I accidentally pulled in a random Yarn file that was also causing compilation errors in addition to the one caused by this missing import. I'm going to open a new PR to back port #2363 into branch-1.1 properly.

Closing this.

@andrewor14 andrewor14 closed this Sep 12, 2014
@andrewor14 andrewor14 deleted the compilation-hot-fix-1.1 branch September 12, 2014 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants