[SPARK-26151][SQL][FOLLOWUP] Return partial results for bad CSV records #23235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cloud-fan Please, have a look at the PR. |
|
Test build #99720 has finished for PR 23235 at commit
|
HyukjinKwon
reviewed
Dec 5, 2018
docs/sql-migration-guide-upgrade.md
Outdated
| @@ -35,6 +35,8 @@ displayTitle: Spark SQL Upgrading Guide | |||
|
|
|||
| - Since Spark 3.0, CSV datasource uses java.time API for parsing and generating CSV content. New formatting implementation supports date/timestamp patterns conformed to ISO 8601. To switch back to the implementation used in Spark 2.4 and earlier, set `spark.sql.legacy.timeParser.enabled` to `true`. | |||
|
|
|||
| - In Spark version 2.4 and earlier, CSV datasource converts a malformed CSV string to a row with all `null`s in the PERMISSIVE mode if specified schema is `StructType`. Since Spark 3.0, returned row can contain non-`null` fields if some of CSV column values were parsed and converted to desired types successfully. | |||
There was a problem hiding this comment.
Ah, from_csv and to_csv are added in 3.0 so it's intentionally not mentioned. BTW, I think CSV functionalities can only have StructType so maybe we don't have to mention.
There was a problem hiding this comment.
you are right. I will remove the part about StructType
HyukjinKwon
approved these changes
Dec 5, 2018
cloud-fan
approved these changes
Dec 5, 2018
|
Test build #99728 has finished for PR 23235 at commit
|
|
thanks, merging to master! |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? Updated SQL migration guide according to changes in apache#23120 Closes apache#23235 from MaxGekk/failuresafe-partial-result-followup. Lead-authored-by: Maxim Gekk <maxim.gekk@databricks.com> Co-authored-by: Maxim Gekk <max.gekk@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Updated SQL migration guide according to changes in #23120