Skip to content

[SPARK-25578][BUILD] Update to Scala 2.12.7 #22600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

srowen
Copy link
Member

@srowen srowen commented Oct 1, 2018

What changes were proposed in this pull request?

Update to Scala 2.12.7. See https://issues.apache.org/jira/browse/SPARK-25578 for why.

How was this patch tested?

Existing tests.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM (pending Jenkins).

@SparkQA
Copy link

SparkQA commented Oct 1, 2018

Test build #96817 has finished for PR 22600 at commit 1e64cdf.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Oct 2, 2018
## What changes were proposed in this pull request?

Update to Scala 2.12.7. See https://issues.apache.org/jira/browse/SPARK-25578 for why.

## How was this patch tested?

Existing tests.

Closes #22600 from srowen/SPARK-25578.

Authored-by: Sean Owen <sean.owen@databricks.com>
Signed-off-by: Sean Owen <sean.owen@databricks.com>
(cherry picked from commit 5114db5)
Signed-off-by: Sean Owen <sean.owen@databricks.com>
@srowen
Copy link
Member Author

srowen commented Oct 2, 2018

Merged to master/2.4

@asfgit asfgit closed this in 5114db5 Oct 2, 2018
@srowen srowen deleted the SPARK-25578 branch October 10, 2018 22:30
@wangyum
Copy link
Member

wangyum commented Dec 4, 2018

2.12.8 is out. Do we need to upgrade to 2.12.8?
2.12.8 fixes two regressions that appeared in 2.12.7:

Don't reject views with result types which are TypeVars (#7295)
Don't emit static forwarders (which simplify the use of methods in top-level objects from Java) for bridge methods (#7469)

More details: https://github.com/scala/scala/releases/tag/v2.12.8

@srowen
Copy link
Member Author

srowen commented Dec 4, 2018

@wangyum sounds good. I opened #23218

jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
## What changes were proposed in this pull request?

Update to Scala 2.12.7. See https://issues.apache.org/jira/browse/SPARK-25578 for why.

## How was this patch tested?

Existing tests.

Closes apache#22600 from srowen/SPARK-25578.

Authored-by: Sean Owen <sean.owen@databricks.com>
Signed-off-by: Sean Owen <sean.owen@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants