Skip to content

[SPARK-24598][DOCS] State in the documentation the behavior when arithmetic operations cause overflow #21967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mgaido91
Copy link
Contributor

@mgaido91 mgaido91 commented Aug 2, 2018

What changes were proposed in this pull request?

According to the discussion in #21599, changing the behavior of arithmetic operations so that they can check for overflow is not nice in a minor release. What we can do for 2.4 is warn users about the current behavior in the documentation, so that they are aware of the issue and can take proper actions.

How was this patch tested?

NA

@mgaido91
Copy link
Contributor Author

mgaido91 commented Aug 2, 2018

cc @cloud-fan

@SparkQA
Copy link

SparkQA commented Aug 2, 2018

Test build #93992 has finished for PR 21967 at commit 67e5f8d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

LGTM, cc @gatorsmile @hvanhovell @rxin

Copy link
Member

@gatorsmile gatorsmile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Merged to master.

@asfgit asfgit closed this in ad2e636 Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants