[SPARK-24308][SQL] Handle DataReaderFactory to InputPartition rename in left over classes #21355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunmahadevan
changed the title
Contributor
Author
|
ping @rdblue , @gatorsmile , @cloud-fan |
|
Test build #90743 has finished for PR 21355 at commit
|
cloud-fan
reviewed
May 18, 2018
|
|
||
| /** | ||
| * The overall strategy here is: | ||
| * * ContinuousMemoryStream maintains a list of records for each partition. addData() will |
Contributor
There was a problem hiding this comment.
why remove the star mark?
Contributor
|
LGTM, cc @jose-torres |
|
Test build #90800 has finished for PR 21355 at commit
|
Contributor
|
LGTM. Thanks for handling this! |
Member
|
Thanks! Merged to master. |
jzhuge
pushed a commit
to jzhuge/spark
that referenced
this pull request
Mar 7, 2019
…in left over classes SPARK-24073 renames DataReaderFactory -> InputPartition and DataReader -> InputPartitionReader. Some classes still reflects the old name and causes confusion. This patch renames the left over classes to reflect the new interface and fixes a few comments. Existing unit tests. Please review http://spark.apache.org/contributing.html before opening a pull request. Author: Arun Mahadevan <arunm@apache.org> Closes apache#21355 from arunmahadevan/SPARK-24308. (cherry picked from commit 710e4e8) Conflicts: common/unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryLocation.java external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchReader.scala external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSourceSuite.scala sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/memory.scala sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/ContinuousMemoryStream.scala sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/RateStreamMicroBatchReader.scala sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/RateSourceSuite.scala sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/RateSourceV2Suite.scala
jzhuge
pushed a commit
to jzhuge/spark
that referenced
this pull request
Oct 15, 2019
…in left over classes SPARK-24073 renames DataReaderFactory -> InputPartition and DataReader -> InputPartitionReader. Some classes still reflects the old name and causes confusion. This patch renames the left over classes to reflect the new interface and fixes a few comments. Existing unit tests. Please review http://spark.apache.org/contributing.html before opening a pull request. Author: Arun Mahadevan <arunm@apache.org> Closes apache#21355 from arunmahadevan/SPARK-24308. (cherry picked from commit 710e4e8) Conflicts: common/unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryLocation.java external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchReader.scala external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSourceSuite.scala sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/memory.scala sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/ContinuousMemoryStream.scala sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/RateStreamMicroBatchReader.scala sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/RateSourceSuite.scala sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/RateSourceV2Suite.scala
otterc
pushed a commit
to linkedin/spark
that referenced
this pull request
Mar 22, 2023
…in left over classes SPARK-24073 renames DataReaderFactory -> InputPartition and DataReader -> InputPartitionReader. Some classes still reflects the old name and causes confusion. This patch renames the left over classes to reflect the new interface and fixes a few comments. Existing unit tests. Please review http://spark.apache.org/contributing.html before opening a pull request. Author: Arun Mahadevan <arunm@apache.org> Closes apache#21355 from arunmahadevan/SPARK-24308. Ref: LIHADOOP-48531
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SPARK-24073 renames DataReaderFactory -> InputPartition and DataReader -> InputPartitionReader. Some classes still reflects the old name and causes confusion. This patch renames the left over classes to reflect the new interface and fixes a few comments.
How was this patch tested?
Existing unit tests.
Please review http://spark.apache.org/contributing.html before opening a pull request.