[SPARK-22757][K8S] Enable spark.jars and spark.files in KUBERNETES mode #20157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good pending tests. |
|
LGTM, thanks! |
|
Please open the PR against master. |
|
Test build #85698 has finished for PR 20157 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Jan 5, 2018
## What changes were proposed in this pull request? We missed enabling `spark.files` and `spark.jars` in #19954. The result is that remote dependencies specified through `spark.files` or `spark.jars` are not included in the list of remote dependencies to be downloaded by the init-container. This PR fixes it. ## How was this patch tested? Manual tests. vanzin This replaces #20157. foxish Author: Yinan Li <liyinan926@gmail.com> Closes #20160 from liyinan926/SPARK-22757. (cherry picked from commit 6cff7d1) Signed-off-by: Felix Cheung <felixcheung@apache.org>
zzcclp
pushed a commit
to zzcclp/spark
that referenced
this pull request
Jan 5, 2018
## What changes were proposed in this pull request? We missed enabling `spark.files` and `spark.jars` in apache#19954. The result is that remote dependencies specified through `spark.files` or `spark.jars` are not included in the list of remote dependencies to be downloaded by the init-container. This PR fixes it. ## How was this patch tested? Manual tests. vanzin This replaces apache#20157. foxish Author: Yinan Li <liyinan926@gmail.com> Closes apache#20160 from liyinan926/SPARK-22757.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We missed enabling
spark.filesandspark.jarsin #19954. The result is that remote dependencies specified throughspark.filesorspark.jarsare not included in the list of remote dependencies to be downloaded by the init-container. This PR fixes it.How was this patch tested?
Manual tests.
@vanzin Can you help review? Thanks!
@foxish