Skip to content

Conversation

gatorsmile
Copy link
Member

What changes were proposed in this pull request?

Added a test case for using joins with nested fields.

How was this patch tested?

N/A

@gatorsmile
Copy link
Member Author

cc @cloud-fan @hvanhovell

@SparkQA
Copy link

SparkQA commented Dec 2, 2016

Test build #69513 has finished for PR 16110 at commit e754ef5.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member Author

retest this please

@cloud-fan
Copy link
Contributor

shall we put the test in ResolveNaturalJoinSuite and follow the code style there?

@rxin
Copy link
Contributor

rxin commented Dec 2, 2016

OK if you are improving this, can you fix the grammar? "USING column col1.field1 can not be resolved with the left join side, the left output is: [col1]" technically is grammatically incorrect.

@gatorsmile
Copy link
Member Author

Sure, will do it. Thanks!

@SparkQA
Copy link

SparkQA commented Dec 2, 2016

Test build #69522 has finished for PR 16110 at commit e754ef5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member Author

Just tried MySQL. The message is not good to me:

mysql> select * from t1 inner join t2 using (col2);
ERROR 1054 (42S22): Unknown column 'col2' in 'from clause'

Will try to improve it by:

Using column `col1.field1` cannot be resolved on the left side of the join. The left-side columns: [col1]

@rxin
Copy link
Contributor

rxin commented Dec 2, 2016

That SGTM

@SparkQA
Copy link

SparkQA commented Dec 2, 2016

Test build #69548 has started for PR 16110 at commit 4d43bca.

@rxin
Copy link
Contributor

rxin commented Dec 2, 2016

LGTM pending tests.

@gatorsmile
Copy link
Member Author

retest this please

@SparkQA
Copy link

SparkQA commented Dec 2, 2016

Test build #69554 has finished for PR 16110 at commit 4d43bca.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Dec 2, 2016
### What changes were proposed in this pull request?
Added a test case for using joins with nested fields.

### How was this patch tested?
N/A

Author: gatorsmile <gatorsmile@gmail.com>

Closes #16110 from gatorsmile/followup-18674.

(cherry picked from commit 2f8776c)
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
@asfgit asfgit closed this in 2f8776c Dec 2, 2016
@cloud-fan
Copy link
Contributor

thanks, merging to master/2.1!

robert3005 pushed a commit to palantir/spark that referenced this pull request Dec 15, 2016
### What changes were proposed in this pull request?
Added a test case for using joins with nested fields.

### How was this patch tested?
N/A

Author: gatorsmile <gatorsmile@gmail.com>

Closes apache#16110 from gatorsmile/followup-18674.
uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
### What changes were proposed in this pull request?
Added a test case for using joins with nested fields.

### How was this patch tested?
N/A

Author: gatorsmile <gatorsmile@gmail.com>

Closes apache#16110 from gatorsmile/followup-18674.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants