Skip to content

[Doc] Fix typo in sql hive doc #15485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Doc] Fix typo in sql hive doc #15485

wants to merge 1 commit into from

Conversation

dhruve
Copy link
Contributor

@dhruve dhruve commented Oct 14, 2016

Change is too trivial to file a JIRA.

@HyukjinKwon
Copy link
Member

Maybe I think you could try to find other typoes together (at least in other docs as you fix a typo in documentation). It seems too minor in my opinion.

@dhruve
Copy link
Contributor Author

dhruve commented Oct 14, 2016

I wasn't scanning explicitly for these typoes. I have seen individual commits addressing such typoes earlier so submitted the super trivial change. If unnecessary we can close this.

@SparkQA
Copy link

SparkQA commented Oct 14, 2016

Test build #66963 has finished for PR 15485 at commit dbccde0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Oct 14, 2016

Yeap, it is true and I think it is acceptable but maybe we should avoid. I guess we don't want flooding small fixes for a single typo. (This is just what I have thought consistently for those PRs not only this one)

@srowen
Copy link
Member

srowen commented Oct 14, 2016

Yeah, I'd prefer to encourage fixing a bunch of stuff at once, and discourage truly non-functional changes that don't meaningfully clarify something. If you add up the time everyone spends looking at it it's, shockingly, like hundreds of dollars of time. OK, I can merge it as the fastest way to resolve this but it's not worth it in general.

@srowen srowen mentioned this pull request Oct 14, 2016
@asfgit asfgit closed this in a0ebcb3 Oct 14, 2016
robert3005 pushed a commit to palantir/spark that referenced this pull request Nov 1, 2016
Change is too trivial to file a JIRA.

Author: Dhruve Ashar <dhruveashar@gmail.com>

Closes apache#15485 from dhruve/master.
uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
Change is too trivial to file a JIRA.

Author: Dhruve Ashar <dhruveashar@gmail.com>

Closes apache#15485 from dhruve/master.
@dhruve dhruve deleted the master branch June 23, 2017 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants