Skip to content

SPARK-1680: use configs for specifying environment variables on YARN #1512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

tgravescs
Copy link
Contributor

Note that this also documents spark.executorEnv.* which to me means its public. If we don't want that please speak up.

@SparkQA
Copy link

SparkQA commented Jul 21, 2014

QA tests have started for PR 1512. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16912/consoleFull

@SparkQA
Copy link

SparkQA commented Jul 21, 2014

QA results for PR 1512:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16912/consoleFull

@tgravescs
Copy link
Contributor Author

I need to update so the documentation shows up properly

@SparkQA
Copy link

SparkQA commented Jul 21, 2014

QA tests have started for PR 1512. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16916/consoleFull

@SparkQA
Copy link

SparkQA commented Jul 21, 2014

QA tests have started for PR 1512. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16917/consoleFull

@SparkQA
Copy link

SparkQA commented Jul 21, 2014

QA results for PR 1512:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16917/consoleFull

@tgravescs
Copy link
Contributor Author

@pwendell are you ok with exposing the spark.executorEnv. config?

@mateiz
Copy link
Contributor

mateiz commented Jul 27, 2014

@tgravescs I think it's fine to expose that. We actually already document it in the comments of SparkConf.setExecutorEnv and such.

asfgit pushed a commit that referenced this pull request Aug 5, 2014
Note that this also documents spark.executorEnv.*  which to me means its public.  If we don't want that please speak up.

Author: Thomas Graves <tgraves@apache.org>

Closes #1512 from tgravescs/SPARK-1680 and squashes the following commits:

11525df [Thomas Graves] more doc changes
553bad0 [Thomas Graves] fix documentation
152bf7c [Thomas Graves] fix docs
5382326 [Thomas Graves] try fix docs
32f86a4 [Thomas Graves] use configs for specifying environment variables on YARN

(cherry picked from commit 41e0a21)
Signed-off-by: Thomas Graves <tgraves@apache.org>
@asfgit asfgit closed this in 41e0a21 Aug 5, 2014
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
Note that this also documents spark.executorEnv.*  which to me means its public.  If we don't want that please speak up.

Author: Thomas Graves <tgraves@apache.org>

Closes apache#1512 from tgravescs/SPARK-1680 and squashes the following commits:

11525df [Thomas Graves] more doc changes
553bad0 [Thomas Graves] fix documentation
152bf7c [Thomas Graves] fix docs
5382326 [Thomas Graves] try fix docs
32f86a4 [Thomas Graves] use configs for specifying environment variables on YARN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants