[SPARK-14028][STREAMING][KINESIS][TESTS] Remove deprecated methods; fix two other warnings #11850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "https://kinesis.us-west-2.amazonaws.com", new Duration(2000), | ||
| InitialPositionInStream.LATEST, StorageLevel.MEMORY_AND_DISK_2()); | ||
| String dummyEndpointUrl = KinesisTestUtils.defaultEndpointUrl(); | ||
| String dummyRegionName = RegionUtils.getRegionByEndpoint(dummyEndpointUrl).getName(); | ||
|
|
There was a problem hiding this comment.
This JavaDStream is created by the deprecated & removed createStream method; so let's switch to another createStream method.
|
OK by me |
| @@ -40,7 +40,7 @@ trait KinesisFunSuite extends SparkFunSuite { | |||
| if (shouldRunTests) { | |||
| body | |||
| } else { | |||
| ignore(s"$message [enable by setting env var $envVarNameForEnablingTests=1]")() | |||
| ignore(s"$message [enable by setting env var $envVarNameForEnablingTests=1]")(()) | |||
There was a problem hiding this comment.
Without the (), scalac will add this () implicitly and then complain that this is probably not we want. So let's add this () explicitly to erase this warning.
|
Jenkins test this please |
|
Test build #53630 has finished for PR 11850 at commit
|
|
Merged to master |
|
@srowen thanks for the review! |
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
…ix two other warnings ## What changes were proposed in this pull request? - Removed two methods that has been deprecated since 1.4 - Fixed two other compilation warnings ## How was this patch tested? existing test suits Author: proflin <proflin.me@gmail.com> Closes apache#11850 from lw-lin/streaming-kinesis-deprecates-warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
How was this patch tested?
existing test suits