[SPARK-13478] [yarn] Use real user when fetching delegation tokens. #11358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 24, 2016 18:10
The Hive client library is not smart enough to notice that the current user is a proxy user; so when using a proxy user, it fails to fetch delegation tokens from the metastore because of a missing kerberos TGT for the current user. To fix it, just run the code that fetches the delegation token as the real logged in user. Tested on a kerberos cluster both submitting normally and with a proxy user; Hive and HBase tokens are retrieved correctly in both cases.
|
Test build #51921 has finished for PR 11358 at commit
|
|
So I have not tested using the keytab-based login with proxy user stuff at all. We get delegation tokens even there - does this issue affect that as well? |
|
This looks like it might affect HDFS tokens as well and error that looks like this might come up during the initial token renewal: In addition to the code that gets the new tokens, I think the |
That is not expected to work. Just use the proper user's credentials if you're going to provide a principal and a keytab. |
| @@ -171,8 +173,8 @@ class YarnSparkHadoopUtil extends SparkHadoopUtil { | |||
| * @param username the username of the principal requesting the delegating token. | |||
| * @return a delegation token | |||
| */ | |||
| private[yarn] def obtainTokenForHiveMetastoreInner(conf: Configuration, | |||
| username: String): Option[Token[DelegationTokenIdentifier]] = { | |||
| private[yarn] def obtainTokenForHiveMetastoreInner(conf: Configuration): | |||
There was a problem hiding this comment.
only reason I thought this was passed in was for testing, is that not the case?
There was a problem hiding this comment.
The sole test for this code didn't seem to do any verification of the given user name, so it didn't seem necessary to have a parameter here.
|
the code looks fine to me. Do we need any more documentation to explain proxy user vs keytab? |
Ok, ok, I'll add something. |
|
looks fine. +1 pending jenkins. @harishreedharan any other concerns? |
|
LGTM |
|
Test build #52058 has finished for PR 11358 at commit
|
|
Merging this. |
|
hi @vanzin, how about spark sql in this issue, in your view? as in spark sql it will revoke SessionState.start in which will finally connected to metastore in Hive. |
|
@WangTaoTheTonic please don't comment on closed PRs. If there's a bug in Spark SQL, file a bug. |
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
The Hive client library is not smart enough to notice that the current user is a proxy user; so when using a proxy user, it fails to fetch delegation tokens from the metastore because of a missing kerberos TGT for the current user. To fix it, just run the code that fetches the delegation token as the real logged in user. Tested on a kerberos cluster both submitting normally and with a proxy user; Hive and HBase tokens are retrieved correctly in both cases. Author: Marcelo Vanzin <vanzin@cloudera.com> Closes apache#11358 from vanzin/SPARK-13478.
vanzin
pushed a commit
to vanzin/spark
that referenced
this pull request
Jan 20, 2017
The Hive client library is not smart enough to notice that the current user is a proxy user; so when using a proxy user, it fails to fetch delegation tokens from the metastore because of a missing kerberos TGT for the current user. To fix it, just run the code that fetches the delegation token as the real logged in user. Tested on a kerberos cluster both submitting normally and with a proxy user; Hive and HBase tokens are retrieved correctly in both cases. Author: Marcelo Vanzin <vanzin@cloudera.com> Closes apache#11358 from vanzin/SPARK-13478. (cherry picked from commit c7fccb5)
asfgit
pushed a commit
that referenced
this pull request
Jan 22, 2017
The Hive client library is not smart enough to notice that the current user is a proxy user; so when using a proxy user, it fails to fetch delegation tokens from the metastore because of a missing kerberos TGT for the current user. To fix it, just run the code that fetches the delegation token as the real logged in user. Tested on a kerberos cluster both submitting normally and with a proxy user; Hive and HBase tokens are retrieved correctly in both cases. Author: Marcelo Vanzin <vanzincloudera.com> Closes #11358 from vanzin/SPARK-13478. (cherry picked from commit c7fccb5) Author: Marcelo Vanzin <vanzin@cloudera.com> Closes #16665 from vanzin/SPARK-13478_1.6.
zzcclp
pushed a commit
to zzcclp/spark
that referenced
this pull request
Jan 22, 2017
The Hive client library is not smart enough to notice that the current user is a proxy user; so when using a proxy user, it fails to fetch delegation tokens from the metastore because of a missing kerberos TGT for the current user. To fix it, just run the code that fetches the delegation token as the real logged in user. Tested on a kerberos cluster both submitting normally and with a proxy user; Hive and HBase tokens are retrieved correctly in both cases. Author: Marcelo Vanzin <vanzincloudera.com> Closes apache#11358 from vanzin/SPARK-13478. (cherry picked from commit c7fccb5) Author: Marcelo Vanzin <vanzin@cloudera.com> Closes apache#16665 from vanzin/SPARK-13478_1.6. (cherry picked from commit e78138a)
mgummelt
pushed a commit
to d2iq-archive/spark
that referenced
this pull request
Mar 7, 2017
The Hive client library is not smart enough to notice that the current user is a proxy user; so when using a proxy user, it fails to fetch delegation tokens from the metastore because of a missing kerberos TGT for the current user. To fix it, just run the code that fetches the delegation token as the real logged in user. Tested on a kerberos cluster both submitting normally and with a proxy user; Hive and HBase tokens are retrieved correctly in both cases. Author: Marcelo Vanzin <vanzincloudera.com> Closes apache#11358 from vanzin/SPARK-13478. (cherry picked from commit c7fccb5) Author: Marcelo Vanzin <vanzin@cloudera.com> Closes apache#16665 from vanzin/SPARK-13478_1.6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Hive client library is not smart enough to notice that the current
user is a proxy user; so when using a proxy user, it fails to fetch
delegation tokens from the metastore because of a missing kerberos
TGT for the current user.
To fix it, just run the code that fetches the delegation token as the
real logged in user.
Tested on a kerberos cluster both submitting normally and with a proxy
user; Hive and HBase tokens are retrieved correctly in both cases.