Feedback.

Author: Marcelo Vanzin

launcher/src/main/java/org/apache/spark/launcher/ChildProcAppHandle.java

@@ -49,14 +49,12 @@ public synchronized void disconnect() {
 
   /**
    * Parses the logs of {@code spark-submit} and returns the last exception thrown.
-   *
    * <p>
-   *   Since {@link SparkLauncher} runs {@code spark-submit} in a sub-process, its difficult to
-   *   accurately retrieve the full {@link Throwable} from the {@code spark-submit} process.
-   *   This method parses the logs of the sub-process and provides a best-effort attempt at
-   *   returning the last exception thrown by the {@code spark-submit} process. Only the exception
-   *   message is parsed, the associated stacktrace is meaningless.
-   * </p>
+   * Since {@link SparkLauncher} runs {@code spark-submit} in a sub-process, it's difficult to
+   * accurately retrieve the full {@link Throwable} from the {@code spark-submit} process.
+   * This method parses the logs of the sub-process and provides a best-effort attempt at
+   * returning the last exception thrown by the {@code spark-submit} process. Only the exception
+   * message is parsed, the associated stacktrace is meaningless.
    *
    * @return an {@link Optional} containing a {@link RuntimeException} with the parsed
    * exception, otherwise returns a {@link Optional#EMPTY}

launcher/src/main/java/org/apache/spark/launcher/OutputRedirector.java

@@ -62,8 +62,7 @@ private void redirect() {
       while ((line = reader.readLine()) != null) {
         if (active) {
           sink.info(line.replaceFirst("\\s*$", ""));
-          if (error == null && containsIgnoreCase(line, "Error") || containsIgnoreCase(line,
-                  "Exception")) {
+          if (containsIgnoreCase(line, "Error") || containsIgnoreCase(line, "Exception")) {
             error = new RuntimeException(line);
           }
         }