Skip to content

Commit e10be0a

Browse files
committed
fix
1 parent ab53ff5 commit e10be0a

File tree

3 files changed

+7
-35
lines changed

3 files changed

+7
-35
lines changed

connector/connect/client/jvm/pom.xml

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -51,15 +51,9 @@
5151
<version>${project.version}</version>
5252
</dependency>
5353
<!--
54-
We need to define guava and protobuf here because we need to change the scope of both from
54+
We need to define protobuf here because we need to change the scope of both from
5555
provided to compile. If we don't do this we can't shade these libraries.
5656
-->
57-
<dependency>
58-
<groupId>com.google.guava</groupId>
59-
<artifactId>guava</artifactId>
60-
<version>${connect.guava.version}</version>
61-
<scope>compile</scope>
62-
</dependency>
6357
<dependency>
6458
<groupId>com.google.protobuf</groupId>
6559
<artifactId>protobuf-java</artifactId>
@@ -137,10 +131,6 @@
137131
<include>io.grpc.**</include>
138132
</includes>
139133
</relocation>
140-
<relocation>
141-
<pattern>com.google.common</pattern>
142-
<shadedPattern>${spark.shade.packageName}.connect.guava</shadedPattern>
143-
</relocation>
144134
<relocation>
145135
<pattern>com.google</pattern>
146136
<shadedPattern>${spark.shade.packageName}.com.google</shadedPattern>

connector/connect/common/pom.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,11 @@
4747
<groupId>com.google.protobuf</groupId>
4848
<artifactId>protobuf-java</artifactId>
4949
</dependency>
50+
<!--
51+
SPARK-45593: spark connect relies on a specific version of Guava, We perform shading
52+
of the Guava library within the connect-common module to ensure both connect-server and
53+
connect-client modules maintain consistent and accurate Guava dependencies.
54+
-->
5055
<dependency>
5156
<groupId>com.google.guava</groupId>
5257
<artifactId>guava</artifactId>
@@ -154,6 +159,7 @@
154159
<includes>
155160
<include>org.spark-project.spark:unused</include>
156161
<include>com.google.guava:guava</include>
162+
<include>com.google.guava:failureaccess</include>
157163
<include>org.apache.tomcat:annotations-api</include>
158164
</includes>
159165
</artifactSet>

connector/connect/server/pom.xml

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,6 @@
5151
<groupId>org.apache.spark</groupId>
5252
<artifactId>spark-connect-common_${scala.binary.version}</artifactId>
5353
<version>${project.version}</version>
54-
<exclusions>
55-
<exclusion>
56-
<groupId>com.google.guava</groupId>
57-
<artifactId>guava</artifactId>
58-
</exclusion>
59-
</exclusions>
6054
</dependency>
6155
<dependency>
6256
<groupId>org.apache.spark</groupId>
@@ -156,17 +150,6 @@
156150
<groupId>org.scala-lang.modules</groupId>
157151
<artifactId>scala-parallel-collections_${scala.binary.version}</artifactId>
158152
</dependency>
159-
<dependency>
160-
<groupId>com.google.guava</groupId>
161-
<artifactId>guava</artifactId>
162-
<version>${connect.guava.version}</version>
163-
<scope>compile</scope>
164-
</dependency>
165-
<dependency>
166-
<groupId>com.google.guava</groupId>
167-
<artifactId>failureaccess</artifactId>
168-
<version>${guava.failureaccess.version}</version>
169-
</dependency>
170153
<dependency>
171154
<groupId>com.google.protobuf</groupId>
172155
<artifactId>protobuf-java</artifactId>
@@ -306,13 +289,6 @@
306289
</includes>
307290
</artifactSet>
308291
<relocations>
309-
<relocation>
310-
<pattern>com.google.common</pattern>
311-
<shadedPattern>${spark.shade.packageName}.connect.guava</shadedPattern>
312-
<includes>
313-
<include>com.google.common.**</include>
314-
</includes>
315-
</relocation>
316292
<relocation>
317293
<pattern>com.google.thirdparty</pattern>
318294
<shadedPattern>${spark.shade.packageName}.connect.guava</shadedPattern>

0 commit comments

Comments
 (0)