Skip to content

Commit c82fc5b

Browse files
committed
address comments
1 parent e3a7a07 commit c82fc5b

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,15 @@
3131
*
3232
* ColumnVector supports all the data types including nested types. To handle nested types,
3333
* ColumnVector can have children and is a tree structure. For struct type, it stores the actual
34-
* data of each field in the corresponding child ColumnVector, and only store null information in
34+
* data of each field in the corresponding child ColumnVector, and only stores null information in
3535
* the parent ColumnVector. For array type, it stores the actual array elements in the child
36-
* ColumnVector, and store null information, array offsets and lengths in the parent ColumnVector.
36+
* ColumnVector, and stores null information, array offsets and lengths in the parent ColumnVector.
3737
*
3838
* ColumnVector is expected to be reused during the entire data loading process, to avoid allocating
3939
* memory again and again.
4040
*
41-
* ColumnVector is meant to maximize CPU efficiency but not to minimize storage footprint,
42-
* implementations should prefer computing efficiency over storage efficiency when design the
41+
* ColumnVector is meant to maximize CPU efficiency but not to minimize storage footprint.
42+
* Implementations should prefer computing efficiency over storage efficiency when design the
4343
* format. Since it is expected to reuse the ColumnVector instance while loading data, the storage
4444
* footprint is negligible.
4545
*/

sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnarBatch.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@
2323
import org.apache.spark.sql.types.StructType;
2424

2525
/**
26-
* This class is a wrapper of multiple ColumnVectors and represents a logical table-like data
27-
* structure. It provides a row-view of this batch so that Spark can access the data row by row.
28-
* Instance of it is meant to be reused during the entire data loading process.
26+
* This class wraps multiple ColumnVectors as a row-wise table. It provides a row view of this
27+
* batch so that Spark can access the data row by row. Instance of it is meant to be reused during
28+
* the entire data loading process.
2929
*/
3030
public final class ColumnarBatch {
3131
public static final int DEFAULT_BATCH_SIZE = 4 * 1024;
@@ -79,7 +79,7 @@ public void remove() {
7979
}
8080

8181
/**
82-
* Sets the number of rows that are valid in this batch.
82+
* Sets the number of rows in this batch.
8383
*/
8484
public void setNumRows(int numRows) {
8585
assert(numRows <= this.capacity);

0 commit comments

Comments
 (0)