Skip to content

Commit c80d5c3

Browse files
committed
wrap retries in a try catch block
1 parent b2989d5 commit c80d5c3

File tree

1 file changed

+15
-8
lines changed

1 file changed

+15
-8
lines changed

ec2/spark_ec2.py

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -453,18 +453,25 @@ def launch_cluster(conn, opts, cluster_name):
453453
for master in master_nodes:
454454
name = '{cn}-master-{iid}'.format(cn=cluster_name, iid=master.id)
455455
for i in range(0, 5):
456-
master.add_tag(key='Name', value=name)
457-
if master.tags.get(u'Name', "") == name:
458-
break
459-
print "Failed attempt %i of 5 to tag %s" % ((i + 1), name)
456+
try:
457+
master.add_tag(key='Name', value=name)
458+
except:
459+
print "Failed attempt %i of 5 to tag %s" % ((i + 1), name)
460+
if (i == 5):
461+
raise "Error - failed max attempts to add name tag"
462+
time.sleep(5)
463+
460464

461465
for slave in slave_nodes:
462466
name = '{cn}-slave-{iid}'.format(cn=cluster_name, iid=slave.id)
463467
for i in range(0, 5):
464-
slave.add_tag(key='Name', value=name)
465-
if slave.tags.get(u'Name', "") == name:
466-
break
467-
print "Failed attempt %i of 5 to tag %s" % ((i + 1), name)
468+
try:
469+
slave.add_tag(key='Name', value=name)
470+
except:
471+
print "Failed attempt %i of 5 to tag %s" % ((i + 1), name)
472+
if (i == 5):
473+
raise "Error - failed max attempts to add name tag"
474+
time.sleep(5)
468475

469476
# Return all the instances
470477
return (master_nodes, slave_nodes)

0 commit comments

Comments
 (0)