Skip to content

Commit a2c0557

Browse files
committed
CR feedback (clarify comment and log statement)
1 parent ea8efc7 commit a2c0557

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ private[spark] class CoarseGrainedExecutorBackend(
289289

290290
private def decommissionSelf(): Boolean = {
291291
if (!decommissioned) {
292-
logInfo("Decommissioning self w/sync")
292+
logInfo("Decommissioning self and starting background thread to exit when done.")
293293
try {
294294
decommissioned = true
295295
// Tell master we are are decommissioned so it stops trying to schedule us

core/src/main/scala/org/apache/spark/executor/Executor.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -230,10 +230,10 @@ private[spark] class Executor(
230230
private[executor] def numRunningTasks: Int = runningTasks.size()
231231

232232
/**
233-
* Mark an executor for decommissioning and avoid launching new tasks.
233+
* Mark an executor for decommissioning.
234234
*/
235235
private[spark] def decommission(): Unit = {
236-
logInfo("Executor asked to decommission. Starting shutdown thread.")
236+
logInfo("Executor asked to decommission.")
237237
decommissioned = true
238238
}
239239

core/src/main/scala/org/apache/spark/storage/BlockManager.scala

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1890,6 +1890,8 @@ private[spark] class BlockManager(
18901890
* Note: this does not delete the shuffle files in-case there is an in-progress fetch
18911891
* but rather shadows them.
18921892
* Requires an Indexed based shuffle resolver.
1893+
*
1894+
* @return true if we have not migrated all shuffle blocks, false otherwise.
18931895
*/
18941896
def offloadShuffleBlocks(): Boolean = {
18951897
// Update the queue of shuffles to be migrated

0 commit comments

Comments
 (0)