Addressing PR comments

Author: imback82

sql/core/src/test/resources/sql-tests/inputs/udf/udf-except-all.sql

@@ -32,6 +32,8 @@ MINUS ALL
 SELECT * FROM tab2;
 
 -- EXCEPT ALL same table in both branches
+-- Note that there will one less NULL in the result compared to the non-udf result
+-- because udf converts null to a string "null".
 SELECT * FROM tab1
 EXCEPT ALL
 SELECT * FROM tab2 WHERE udf(c1) IS NOT NULL;
@@ -128,29 +130,29 @@ FROM   (SELECT udf(tab3.k),
                udf(tab4.v)
         FROM   tab3 
                JOIN tab4 
-                 ON tab3.k = tab4.k)
+                 ON udf(tab3.k) = udf(tab4.k))
 EXCEPT ALL 
 SELECT * 
 FROM   (SELECT udf(tab3.k),
                udf(tab4.v)
         FROM   tab3 
                JOIN tab4 
-                 ON tab3.k = tab4.k);
+                 ON udf(tab3.k) = udf(tab4.k));
 
 -- Join under except all (2)
 SELECT * 
 FROM   (SELECT udf(tab3.k),
                udf(tab4.v)
         FROM   tab3 
                JOIN tab4 
-                 ON tab3.k = tab4.k) 
+                 ON udf(tab3.k) = udf(tab4.k))
 EXCEPT ALL 
 SELECT * 
 FROM   (SELECT udf(tab4.v) AS k,
                udf(tab3.k) AS v
         FROM   tab3 
                JOIN tab4 
-                 ON tab3.k = tab4.k);
+                 ON udf(tab3.k) = udf(tab4.k));
 
 -- Group by under ExceptAll
 SELECT udf(v) FROM tab3 GROUP BY v

sql/core/src/test/resources/sql-tests/results/udf/udf-except-all.sql.out

@@ -263,14 +263,14 @@ FROM   (SELECT udf(tab3.k),
                udf(tab4.v)
         FROM   tab3 
                JOIN tab4 
-                 ON tab3.k = tab4.k)
+                 ON udf(tab3.k) = udf(tab4.k))
 EXCEPT ALL 
 SELECT * 
 FROM   (SELECT udf(tab3.k),
                udf(tab4.v)
         FROM   tab3 
                JOIN tab4 
-                 ON tab3.k = tab4.k)
+                 ON udf(tab3.k) = udf(tab4.k))
 -- !query 20 schema
 struct<udf(k):string,udf(v):string>
 -- !query 20 output
@@ -283,14 +283,14 @@ FROM   (SELECT udf(tab3.k),
                udf(tab4.v)
         FROM   tab3 
                JOIN tab4 
-                 ON tab3.k = tab4.k) 
+                 ON udf(tab3.k) = udf(tab4.k))
 EXCEPT ALL 
 SELECT * 
 FROM   (SELECT udf(tab4.v) AS k,
                udf(tab3.k) AS v
         FROM   tab3 
                JOIN tab4 
-                 ON tab3.k = tab4.k)
+                 ON udf(tab3.k) = udf(tab4.k))
 -- !query 21 schema
 struct<udf(k):string,udf(v):string>
 -- !query 21 output