Skip to content

Commit 9babef5

Browse files
committed
[SPARK-25959][ML] GBTClassifier picks wrong impurity stats on loading
1 parent 4afb350 commit 9babef5

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -538,7 +538,7 @@ private[ml] object GBTClassifierParams {
538538
Array("logistic").map(_.toLowerCase(Locale.ROOT))
539539
}
540540

541-
private[ml] trait GBTClassifierParams extends GBTParams with TreeClassifierParams {
541+
private[ml] trait GBTClassifierParams extends GBTParams with TreeRegressorParams {
542542

543543
/**
544544
* Loss function which GBT tries to minimize. (case-insensitive)

mllib/src/test/scala/org/apache/spark/ml/classification/GBTClassifierSuite.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -448,6 +448,7 @@ class GBTClassifierSuite extends MLTest with DefaultReadWriteTest {
448448
model2: GBTClassificationModel): Unit = {
449449
TreeTests.checkEqual(model, model2)
450450
assert(model.numFeatures === model2.numFeatures)
451+
assert(model.featureImportances == model2.featureImportances)
451452
}
452453

453454
val gbt = new GBTClassifier()

0 commit comments

Comments
 (0)