Skip to content

Commit 733b20e

Browse files
committed
address comment
1 parent 049b289 commit 733b20e

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

core/src/main/scala/org/apache/spark/status/storeTypes.scala

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -177,14 +177,13 @@ private[spark] class TaskDataWrapper(
177177
val accumulatorUpdates: Seq[AccumulableInfo],
178178
val errorMessage: Option[String],
179179

180-
// Non successful metrics now will have negative values in `TaskDataWrapper`.
181-
// `TaskData` will have actual metric values. To recover the actual metric value
182-
// from `TaskDataWrapper`, need use `getMetricValue` method.
183180
val hasMetrics: Boolean,
184181
// The following is an exploded view of a TaskMetrics API object. This saves 5 objects
185-
// (= 80 bytes of Java object overhead) per instance of this wrapper. If the first value
186-
// (executorDeserializeTime) is -1L, it means the metrics for this task have not been
187-
// recorded.
182+
// (= 80 bytes of Java object overhead) per instance of this wrapper. Non successful
183+
// tasks' metrics will have negative values in `TaskDataWrapper`. `TaskData` will have
184+
// actual metric values. To recover the actual metric value from `TaskDataWrapper`,
185+
// need use `getMetricValue` method. If `hasMetrics` is false, it means the metrics
186+
// for this task have not been recorded.
188187
@KVIndexParam(value = TaskIndexNames.DESER_TIME, parent = TaskIndexNames.STAGE)
189188
val executorDeserializeTime: Long,
190189
@KVIndexParam(value = TaskIndexNames.DESER_CPU_TIME, parent = TaskIndexNames.STAGE)

core/src/test/scala/org/apache/spark/status/AppStatusStoreSuite.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ class AppStatusStoreSuite extends SparkFunSuite {
161161
}
162162

163163
private def writeTaskDataToStore(i: Int, store: KVStore, status: String): Unit = {
164-
val liveTask = new LiveTask(new TaskInfo( i.toLong, i, i, i.toLong, i.toString,
164+
val liveTask = new LiveTask(new TaskInfo( i.toLong, i, i, i.toLong, i.toString,
165165
i.toString, TaskLocality.ANY, false), stageId, attemptId, None)
166166

167167
if (status == "SUCCESS") {

0 commit comments

Comments
 (0)