Skip to content

Commit 6dfc627

Browse files
committed
fix review comments
1 parent efa5949 commit 6dfc627

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -313,7 +313,7 @@ class CliSuite extends SparkFunSuite with BeforeAndAfterAll with Logging {
313313
Seq("--jars", s"$jarFile"))(
314314
"CREATE TEMPORARY FUNCTION testjar AS" +
315315
" 'org.apache.spark.sql.hive.execution.UDTFStack';" -> "",
316-
"SELECT testjar(1,'A', 10);" -> "A\t10"
316+
"SELECT testjar(1,'TEST-SPARK-TEST-jar', 28840);" -> "TEST-SPARK-TEST-jar\t28840"
317317
)
318318
}
319319

@@ -326,9 +326,9 @@ class CliSuite extends SparkFunSuite with BeforeAndAfterAll with Logging {
326326
s"spark.hadoop.${ConfVars.HIVEAUXJARS}=$hiveContribJar"))(
327327
"CREATE TEMPORARY FUNCTION testjar AS" +
328328
" 'org.apache.spark.sql.hive.execution.UDTFStack';" -> "",
329-
"SELECT testjar(1,'A', 10);" -> "A\t10",
329+
"SELECT testjar(1,'TEST-SPARK-TEST-jar', 28840);" -> "TEST-SPARK-TEST-jar\t28840",
330330
s"CREATE TEMPORARY FUNCTION example_max AS '${classOf[UDAFExampleMax].getName}';" -> "",
331-
"SELECT example_max(1);" -> "1"
331+
"SELECT concat_ws(',', 'First', example_max(1234321), 'Third');" -> "First,1234321,Third"
332332
)
333333
}
334334
}

sql/hive-thriftserver/v2.3.5/src/main/scala/org/apache/spark/sql/hive/thriftserver/ThriftserverShimUtils.scala

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@
1717

1818
package org.apache.spark.sql.hive.thriftserver
1919

20-
import java.security.AccessController
21-
2220
import org.apache.hadoop.hive.ql.session.SessionState
2321
import org.apache.hadoop.hive.serde2.thrift.Type
2422
import org.apache.hadoop.hive.serde2.thrift.Type._

0 commit comments

Comments
 (0)