Skip to content

Commit 62c04ca

Browse files
rootroot
root
authored and
root
committed
fixed PR comments
1 parent fc45425 commit 62c04ca

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -101,11 +101,12 @@ private[ui] class StagePage(parent: StagesTab) extends WebUIPage("stage") {
101101
val parameterTaskPrevPageSize = request.getParameter("task.prevPageSize")
102102

103103
val taskPage = Option(parameterTaskPage).map(_.toInt).getOrElse(1)
104-
val taskSortColumn = Option(parameterTaskSortColumn).map {
105-
sortColumn =>
106-
// If sortColumn contains "/", `getParameter("task.sort")` will return
107-
// "%252F" when yarn mode. we need additional decode.
108-
// See also SPARK-4313, YARN-2844.
104+
val taskSortColumn = Option(parameterTaskSortColumn).map { sortColumn =>
105+
// SPARK-12708
106+
// Due to YARN-2844, "/" in the url will be encoded to "%252F" when
107+
// running in yarn mode. `request.getParameter("task.sort")` will return
108+
// "%252F". Therefore we need to decode it until we get the real column name.
109+
// SPARK-4313 is similar to this issue.
109110
var column = sortColumn
110111
var decodedColumn = URLDecoder.decode(column, "UTF-8")
111112
while (column != decodedColumn) {

0 commit comments

Comments
 (0)