address comments

Author: imback82

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala

@@ -817,8 +817,8 @@ class Analyzer(
 
       case alter @ AlterTable(_, _, u: UnresolvedV2Relation, _) =>
         CatalogV2Util.loadRelation(u.catalog, u.tableName)
-          .map(rel => alter.copy(table = rel))
-          .getOrElse(alter)
+            .map(rel => alter.copy(table = rel))
+            .getOrElse(alter)
 
       case u: UnresolvedV2Relation =>
         CatalogV2Util.loadRelation(u.catalog, u.tableName).getOrElse(u)

sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala

@@ -485,8 +485,8 @@ class ResolveSessionCatalog(
         replace,
         viewType)
 
-    case ShowTableProperties(SessionCatalogAndResolvedTable(resolved), propertyKey) =>
-      ShowTablePropertiesCommand(getTableIdentifier(resolved), propertyKey)
+    case ShowTableProperties(r: ResolvedTable, propertyKey) if isSessionCatalog(r.catalog) =>
+      ShowTablePropertiesCommand(r.identifier.asTableIdentifier, propertyKey)
 
     case DescribeFunctionStatement(CatalogAndIdentifier(catalog, ident), extended) =>
       val functionIdent =
@@ -581,16 +581,6 @@ class ResolveSessionCatalog(
     }
   }
 
-  object SessionCatalogAndResolvedTable {
-    def unapply(resolved: ResolvedTable): Option[ResolvedTable] = {
-      if (isSessionCatalog(resolved.catalog)) {
-        Some(resolved)
-      } else {
-        None
-      }
-    }
-  }
-
   object SessionCatalogAndNamespace {
     def unapply(resolved: ResolvedNamespace): Option[(SupportsNamespaces, Seq[String])] =
       if (isSessionCatalog(resolved.catalog)) {
@@ -600,11 +590,6 @@ class ResolveSessionCatalog(
       }
   }
 
-  private def getTableIdentifier(resolved: ResolvedTable): TableIdentifier = {
-    assert(resolved.identifier.namespace.length < 2)
-    TableIdentifier(resolved.identifier.name, resolved.identifier.namespace.headOption)
-  }
-
   private def assertTopLevelColumn(colName: Seq[String], command: String): Unit = {
     if (colName.length > 1) {
       throw new AnalysisException(s"$command does not support nested column: ${colName.quoted}")