Skip to content

Commit 4928330

Browse files
committed
fix ut failures
1 parent 90b0fd2 commit 4928330

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/decimalExpressions.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ case class MakeDecimal(child: Expression, precision: Int, scale: Int) extends Un
6161
} else {
6262
result.set(longInput, precision, scale)
6363
}
64-
result
6564
}
6665

6766
override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {

sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -111,9 +111,10 @@ final class Decimal extends Ordered[Decimal] with Serializable {
111111
*/
112112
def set(decimal: BigDecimal, precision: Int, scale: Int): Decimal = {
113113
this.decimalVal = decimal.setScale(scale, ROUND_HALF_UP)
114-
require(
115-
decimalVal.precision <= precision,
116-
s"Decimal precision ${decimalVal.precision} exceeds max precision $precision")
114+
if (decimalVal.precision > precision) {
115+
throw new ArithmeticException(
116+
s"Decimal precision ${decimalVal.precision} exceeds max precision $precision")
117+
}
117118
this.longVal = 0L
118119
this._precision = precision
119120
this._scale = scale

sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DecimalExpressionSuite.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ class DecimalExpressionSuite extends SparkFunSuite with ExpressionEvalHelper {
4949
intercept[ArithmeticException](evaluateWithoutCodegen(overflowExpr, null))
5050
intercept[ArithmeticException](checkEvaluationWithUnsafeProjection(overflowExpr, null))
5151
}
52-
5352
}
5453

5554
test("PromotePrecision") {

0 commit comments

Comments
 (0)