Restore prettier exception for non-deterministic case

Author: szehon-ho

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala

@@ -1022,13 +1022,25 @@ trait CheckAnalysis extends LookupCatalog with QueryErrorsBase with PlanToString
       }
     }
 
+    def checkExistsDefaultDeterministic(colsToAdd: Seq[QualifiedColType]): Unit = {
+      colsToAdd.foreach { col =>
+        col.default.foreach { d =>
+          if (!d.deterministic) {
+            throw QueryCompilationErrors.defaultValueNotConstantError(
+              "ALTER TABLE", col.colName, d.originalSQL)
+            }
+        }
+      }
+    }
+
     alter match {
       case AddColumns(table: ResolvedTable, colsToAdd) =>
         colsToAdd.foreach { colToAdd =>
           checkColumnNotExists("add", colToAdd.name, table.schema)
         }
         checkColumnNameDuplication(colsToAdd)
         checkNoCollationsInMapKeys(colsToAdd)
+        checkExistsDefaultDeterministic(colsToAdd)
 
       case ReplaceColumns(_: ResolvedTable, colsToAdd) =>
         checkColumnNameDuplication(colsToAdd)

sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala

@@ -3560,10 +3560,11 @@ class DataSourceV2SQLSuiteV1Filter
         val exception = analysisException(
           // Rand function is not foldable
           s"ALTER TABLE tab ADD COLUMN col2 DOUBLE DEFAULT rand()")
-        assert(exception.getSqlState == "42K0E")
-        assert(exception.errorClass.get == "INVALID_NON_DETERMINISTIC_EXPRESSIONS")
-        assert(exception.messageParameters("sqlExprs") ==
-          "\"qualifiedcoltype(defaultvalueexpression(rand()))\"")
+        assert(exception.getSqlState == "42623")
+        assert(exception.errorClass.get == "INVALID_DEFAULT_VALUE.NOT_CONSTANT")
+        assert(exception.messageParameters("colName") == "`col2`")
+        assert(exception.messageParameters("defaultValue") == "rand()")
+        assert(exception.messageParameters("statement") == "ALTER TABLE")
       }
       foldableExpressions.foreach(expr => {
         withTable("tab") {