add todo

cloud-fan · cloud-fan · commit 39929d9871c9 · 2015-06-01T12:13:31.000+08:00
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
@@ -90,6 +90,8 @@ abstract class Expression extends TreeNode[Expression] {
   /**
    * Check the input data types, returns `TypeCheckResult.success` if it's valid,
    * or return a `TypeCheckResult` with an error message if invalid.
+   * TODO: we should remove the default implementation and implement it for all
+   * expressions with proper error message.
    */
   def checkInputDataTypes(): TypeCheckResult = TypeCheckResult.success
 }

Original file line number	Diff line number	Diff line change
`@@ -90,6 +90,8 @@ abstract class Expression extends TreeNode[Expression] {`
`90`	`90`	`/**`
`91`	`91`	* Check the input data types, returns `TypeCheckResult.success` if it's valid,
`92`	`92`	* or return a `TypeCheckResult` with an error message if invalid.
	`93`	`+ * TODO: we should remove the default implementation and implement it for all`
	`94`	`+ * expressions with proper error message.`
`93`	`95`	`*/`
`94`	`96`	`def checkInputDataTypes(): TypeCheckResult = TypeCheckResult.success`
`95`	`97`	`}`