Skip to content

Commit 31bc1b7

Browse files
committed
address comments
1 parent 2bdd73a commit 31bc1b7

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -252,9 +252,9 @@ final class DataFrameWriter[T] private[sql](ds: Dataset[T]) {
252252
f.fallBackFileFormat
253253
case _ => lookupCls
254254
}
255-
// SPARK-26673: In Data Source V2 project, partitioning is still under development.
256-
// Here we fallback to V1 if the write path if output partitioning is required.
257-
// TODO: use V2 implementations when partitioning feature is supported.
255+
// In Data Source V2 project, partitioning is still under development.
256+
// Here we fallback to V1 if the write path if output partitioning is required.
257+
// TODO(SPARK-26778): use V2 implementations when partitioning feature is supported.
258258
if (classOf[TableProvider].isAssignableFrom(cls) && partitioningColumns.isEmpty) {
259259
val provider = cls.getConstructor().newInstance().asInstanceOf[TableProvider]
260260
val sessionOptions = DataSourceV2Utils.extractSessionConfigs(

sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FallbackOrcDataSourceV2.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ import org.apache.spark.sql.execution.datasources.v2.orc.OrcTable
2828
* Replace the ORC V2 data source of table in [[InsertIntoTable]] to V1 [[FileFormat]].
2929
* E.g, with temporary view `t` using [[FileDataSourceV2]], inserting into view `t` fails
3030
* since there is no corresponding physical plan.
31-
* SPARK-23817: This is a temporary hack for making current data source V2 work. It should be
32-
* removed when Catalog of file data source v2 is finished.
31+
* This is a temporary hack for making current data source V2 work. It should be
32+
* removed when Catalog support of file data source v2 is finished.
3333
*/
3434
class FallbackOrcDataSourceV2(sparkSession: SparkSession) extends Rule[LogicalPlan] {
3535
override def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators {

0 commit comments

Comments
 (0)