Skip to content

Commit 2897281

Browse files
committed
disable stage executor metrics logging by default
1 parent a14b82a commit 2897281

File tree

4 files changed

+9
-2
lines changed

4 files changed

+9
-2
lines changed

core/src/main/scala/org/apache/spark/executor/Executor.scala

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,12 @@ private[spark] class Executor(
217217

218218
def stop(): Unit = {
219219
env.metricsSystem.report()
220-
heartbeater.stop()
220+
try {
221+
heartbeater.stop()
222+
} catch {
223+
case NonFatal(e) =>
224+
logWarning("Unable to stop heartbeater", e)
225+
}
221226
threadPool.shutdown()
222227
if (!isLocal) {
223228
env.stop()

core/src/main/scala/org/apache/spark/internal/config/package.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ package object config {
7272
private[spark] val EVENT_LOG_STAGE_EXECUTOR_METRICS =
7373
ConfigBuilder("spark.eventLog.logStageExecutorMetrics.enabled")
7474
.booleanConf
75-
.createWithDefault(true)
75+
.createWithDefault(false)
7676

7777
private[spark] val EVENT_LOG_OVERWRITE =
7878
ConfigBuilder("spark.eventLog.overwrite").booleanConf.createWithDefault(false)

core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ class HistoryServerSuite extends SparkFunSuite with BeforeAndAfter with Matchers
8282
.set("spark.history.fs.update.interval", "0")
8383
.set("spark.testing", "true")
8484
.set(LOCAL_STORE_DIR, storeDir.getAbsolutePath())
85+
.set("spark.eventLog.logStageExecutorMetrics.enabled", "true")
8586
conf.setAll(extraConf)
8687
provider = new FsHistoryProvider(conf)
8788
provider.checkForLogs()

core/src/test/scala/org/apache/spark/scheduler/EventLoggingListenerSuite.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -517,6 +517,7 @@ object EventLoggingListenerSuite {
517517
conf.set("spark.eventLog.compress", "true")
518518
conf.set("spark.io.compression.codec", codec)
519519
}
520+
conf.set("spark.eventLog.logStageExecutorMetrics.enabled", "true")
520521
conf
521522
}
522523

0 commit comments

Comments
 (0)