Skip to content

Commit 27f78e6

Browse files
sunchaodongjoon-hyun
authored andcommitted
[SPARK-39657][YARN] YARN AM client should call the non-static setTokensConf method
### What changes were proposed in this pull request? This fixes a bug in the original SPARK-37205 PR, where we treat the method `setTokensConf` as a static method, but it should be non-static instead. ### Why are the changes needed? The method `setTokensConf` is non-static so the current code will fail: ``` 06/29/2022 - 17:28:16 - Exception in thread "main" java.lang.IllegalArgumentException: object is not an instance of declaring class 06/29/2022 - 17:28:16 - at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 06/29/2022 - 17:28:16 - at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 06/29/2022 - 17:28:16 - at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) 06/29/2022 - 17:28:16 - at java.base/java.lang.reflect.Method.invoke(Method.java:566) ``` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Manually tested this change internally and it now works. Closes #37050 from sunchao/SPARK-39657. Authored-by: Chao Sun <sunchao@apple.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 6624d91) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
1 parent 2707a5a commit 27f78e6

File tree

1 file changed

+1
-1
lines changed
  • resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn

1 file changed

+1
-1
lines changed

resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -391,7 +391,7 @@ private[spark] class Client(
391391
throw new SparkException(s"Cannot find setTokensConf method in ${amContainer.getClass}." +
392392
s" Please check YARN version and make sure it is 2.9+ or 3.x")
393393
}
394-
setTokensConfMethod.invoke(ByteBuffer.wrap(dob.getData))
394+
setTokensConfMethod.invoke(amContainer, ByteBuffer.wrap(dob.getData))
395395
}
396396
}
397397

0 commit comments

Comments
 (0)