Skip to content

Commit 1806ced

Browse files
committed
For comments.
1 parent 2f643d4 commit 1806ced

File tree

1 file changed

+8
-13
lines changed
  • sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate

1 file changed

+8
-13
lines changed

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Covariance.scala

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -155,17 +155,13 @@ case class CovSample(
155155

156156
override def eval(buffer: InternalRow): Any = {
157157
val count = buffer.getLong(countOffset)
158-
if (count > 0) {
159-
if (count > 1) {
160-
val Ck = buffer.getDouble(CkOffset)
161-
val cov = Ck / (count - 1)
162-
if (cov.isNaN) {
163-
null
164-
} else {
165-
cov
166-
}
167-
} else {
158+
if (count > 1) {
159+
val Ck = buffer.getDouble(CkOffset)
160+
val cov = Ck / (count - 1)
161+
if (cov.isNaN) {
168162
null
163+
} else {
164+
cov
169165
}
170166
} else {
171167
null
@@ -190,11 +186,10 @@ case class CovPopulation(
190186
val count = buffer.getLong(countOffset)
191187
if (count > 0) {
192188
val Ck = buffer.getDouble(CkOffset)
193-
val cov = Ck / count
194-
if (cov.isNaN) {
189+
if (Ck.isNaN) {
195190
null
196191
} else {
197-
cov
192+
Ck / count
198193
}
199194
} else {
200195
null

0 commit comments

Comments
 (0)