Default impl

apache · Dec 22, 2020 · 13bfe3e · 13bfe3e
1 parent 43a7761
commit 13bfe3e
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 15 deletions.
diff --git a/...c/main/java/org/apache/spark/sql/connector/catalog/SupportsAtomicPartitionManagement.java b/...c/main/java/org/apache/spark/sql/connector/catalog/SupportsAtomicPartitionManagement.java
@@ -98,7 +98,11 @@ void createPartitions(
    * @return true if partitions were deleted, false if any partition not exists
    * @throws NoSuchPartitionException If any partition identifier to alter doesn't exist
    * @throws UnsupportedOperationException If partition purging is not supported
+   *
+   * @since 3.2.0
    */
-  boolean purgePartitions(InternalRow[] idents)
-    throws NoSuchPartitionException, UnsupportedOperationException;
+  default boolean purgePartitions(InternalRow[] idents)
+    throws NoSuchPartitionException, UnsupportedOperationException {
+    throw new UnsupportedOperationException("Partition purge is not supported");
+  }
 }
diff --git a/...yst/src/main/java/org/apache/spark/sql/connector/catalog/SupportsPartitionManagement.java b/...yst/src/main/java/org/apache/spark/sql/connector/catalog/SupportsPartitionManagement.java
@@ -83,9 +83,13 @@ void createPartition(
      * @return true if a partition was deleted, false if no partition exists for the identifier
      * @throws NoSuchPartitionException If the partition identifier to alter doesn't exist
      * @throws UnsupportedOperationException If partition purging is not supported
+     *
+     * @since 3.2.0
      */
-    boolean purgePartition(InternalRow ident)
-      throws NoSuchPartitionException, UnsupportedOperationException;
+    default boolean purgePartition(InternalRow ident)
+      throws NoSuchPartitionException, UnsupportedOperationException {
+      throw new UnsupportedOperationException("Partition purge is not supported");
+    }
 
     /**
      * Test whether a partition exists using an {@link InternalRow ident} from the table.

diff --git a/...catalyst/src/test/scala/org/apache/spark/sql/connector/InMemoryAtomicPartitionTable.scala b/...catalyst/src/test/scala/org/apache/spark/sql/connector/InMemoryAtomicPartitionTable.scala
@@ -73,11 +73,4 @@ class InMemoryAtomicPartitionTable (
     }
     idents.forall(dropPartition)
   }
-
-  override def purgePartitions(idents: Array[InternalRow]): Boolean = {
-    if (!idents.forall(partitionExists)) {
-      return false;
-    }
-    idents.forall(purgePartition)
-  }
 }
diff --git a/sql/catalyst/src/test/scala/org/apache/spark/sql/connector/InMemoryPartitionTable.scala b/sql/catalyst/src/test/scala/org/apache/spark/sql/connector/InMemoryPartitionTable.scala
@@ -67,10 +67,6 @@ class InMemoryPartitionTable(
     }
   }
 
-  override def purgePartition(ident: InternalRow): Boolean = {
-    throw new UnsupportedOperationException("Partition purge is not supported")
-  }
-
   def replacePartitionMetadata(ident: InternalRow, properties: util.Map[String, String]): Unit = {
     if (memoryTablePartitions.containsKey(ident)) {
       memoryTablePartitions.put(ident, properties)