Add TODO in JsonProtocol

Andrew Or · Andrew Or · commit 0a2d9a14dbce · 2016-01-18T10:45:16.000-08:00
diff --git a/core/src/main/scala/org/apache/spark/util/JsonProtocol.scala b/core/src/main/scala/org/apache/spark/util/JsonProtocol.scala
@@ -331,6 +331,7 @@ private[spark] object JsonProtocol {
     ("Total Records Read" -> shuffleReadMetrics.recordsRead)
   }
 
+  // TODO: Drop the redundant "Shuffle" since it's inconsistent with related classes.
   def shuffleWriteMetricsToJson(shuffleWriteMetrics: ShuffleWriteMetrics): JValue = {
     ("Shuffle Bytes Written" -> shuffleWriteMetrics.bytesWritten) ~
     ("Shuffle Write Time" -> shuffleWriteMetrics.writeTime) ~

Original file line number	Diff line number	Diff line change
`@@ -331,6 +331,7 @@ private[spark] object JsonProtocol {`
`331`	`331`	`("Total Records Read" -> shuffleReadMetrics.recordsRead)`
`332`	`332`	`}`
`333`	`333`
	`334`	`+ // TODO: Drop the redundant "Shuffle" since it's inconsistent with related classes.`
`334`	`335`	`def shuffleWriteMetricsToJson(shuffleWriteMetrics: ShuffleWriteMetrics): JValue = {`
`335`	`336`	`("Shuffle Bytes Written" -> shuffleWriteMetrics.bytesWritten) ~`
`336`	`337`	`("Shuffle Write Time" -> shuffleWriteMetrics.writeTime) ~`