Skip to content

testing how-to for k8s changes #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

shaneknapp
Copy link
Contributor

i think that this will be quite useful. :)

Copy link
Member

@felixcheung felixcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, esp. the behoove

@tgravescs
Copy link
Contributor

this is great, thanks for writing these up Shane.

@shaneknapp
Copy link
Contributor Author

this is great, thanks for writing these up Shane.

not a problem! after spending 2-3 days helping someone test their PR before finding out they were using the --vm-driver=none arg, i decided that this needed to be documented.

@tgravescs
Copy link
Contributor

lgtm, note I didn't actually try the steps but probably will be in the next couple week.s

@shaneknapp
Copy link
Contributor Author

shaneknapp commented Mar 28, 2019

lgtm, note I didn't actually try the steps but probably will be in the next couple week.s

FWIW, these commands are pulled directly from the k8s integration test build, so things should be relatively simple to get set up on a dev's end.

regarding merging -- do i have perms to run the merge script in the website dir, or does someone else do that for me? ;)

@shaneknapp shaneknapp closed this Mar 28, 2019
@shaneknapp shaneknapp reopened this Mar 28, 2019
@tgravescs
Copy link
Contributor

I'm not sure on permissions

@shaneknapp
Copy link
Contributor Author

alright, i'll try and push from my end and see what happens.

@tgravescs
Copy link
Contributor

ok let us know if it doesn't work

@asfgit asfgit closed this in 5f4985d Mar 28, 2019
@shaneknapp
Copy link
Contributor Author

woot!

@shaneknapp shaneknapp deleted the add-k8s-testing-instructions branch April 1, 2019 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants