[SPARK-49329] Support user provided spec for SparkCluster #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thank you, @jiangzho . Ya, I exclude that intentionally. :)
dongjoon-hyun
requested changes
Aug 21, 2024
| initWorkers: 3 | ||
| minWorkers: 3 | ||
| maxWorkers: 3 | ||
| clusterTolerations: |
There was a problem hiding this comment.
BTW, this is irrelevant to the user provided spec. Please proceed this separately because this means that we need observers. That's the real reason why I decided to exclude this part initially.
| buildMasterService( | ||
| clusterName, | ||
| namespace, | ||
| cluster.getSpec().getMasterSpec().getMasterServiceMetadata(), |
There was a problem hiding this comment.
nit. Just a coding style comment. It's not good to repeat the same thing multiple time. For example, we already have spec as a local variable. So, let's not add a new like this, cluster.getSpec().getMasterSpec().
| @AllArgsConstructor | ||
| @Builder | ||
| @JsonInclude(JsonInclude.Include.NON_NULL) | ||
| public class ClusterInstanceConfig { |
There was a problem hiding this comment.
I'd recommend to use WorkerInstanceConfig because we are not creating multiple cluster instances.
|
Could you rebase this PR, @jiangzho ? |
|
Thank you for updating, @jiangzho . |
mark instance config as required Decouple Worker Instance Config
dongjoon-hyun
approved these changes
Aug 25, 2024
dongjoon-hyun
added a commit
that referenced
this pull request
Aug 26, 2024
### What changes were proposed in this pull request? This PR aims to add `cluster-with-template.yaml` example. ### Why are the changes needed? Apache Spark K8s Operator starts to support template-based Spark Cluster creation via the following. - #80 We had better provide a concrete example like the following use cases. - Custom annotations and labels. - Custom full spec like `priorityClassName`, `securityContext`, `sidecar` containers ### Does this PR introduce _any_ user-facing change? No. This is an unreleased new feature. ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #101 from dongjoon-hyun/SPARK-49380. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Aug 26, 2024
### What changes were proposed in this pull request? This PR aims to support `master` container and `worker` container templates. ### Why are the changes needed? Previously, pod template throws exceptions on containers whose name is `master` or `worker` because two `master|worker` containers were created. After this PR, the problem is resolved. - #80 ### Does this PR introduce _any_ user-facing change? No, this is a new unreleased feature. ### How was this patch tested? For now, we need to run manual tests. ``` $ ./gradlew build buildDockerImage spark-operator-api:relocateGeneratedCRD -x check $ helm install spark-kubernetes-operator -f build-tools/helm/spark-kubernetes-operator/values.yaml build-tools/helm/spark-kubernetes-operator/ $ kubectl apply -f examples/cluster-with-template.yaml $ kubectl get pod -l spark-role=master -oyaml | yq '.items[0].spec.containers[0].resources' limits: cpu: "2" memory: 2Gi requests: cpu: "2" memory: 2Gi ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #104 from dongjoon-hyun/SPARK-49389. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR introduces the feature to enable user-provided metadata & spec for Spark Clusters.
Why are the changes needed?
Similar to pod template spec support for Apps, this is desired when user would like to introduce customization for Cluster master + worker spec.
Does this PR introduce any user-facing change?
No - not released yet
How was this patch tested?
Unit tests and integration test
Was this patch authored or co-authored using generative AI tooling?
No