Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TestClient for fastapi cause the req.client None error #355

Merged
merged 5 commits into from
Nov 6, 2024
Merged

Fix TestClient for fastapi cause the req.client None error #355

merged 5 commits into from
Nov 6, 2024

Conversation

CharlieSeastar
Copy link
Contributor

@CharlieSeastar CharlieSeastar commented Oct 31, 2024 •
edited
Loading

  • Explain briefly why the bug exists and how to fix it: set peers to 'unknown' if req.client is None
  • If this pull request closes/resolves/fixes an existing issue, replace the issue url. Closes: #12733
  • Update the CHANGELOG.md.

@wu-sheng wu-sheng added this to the 1.3.0 milestone Oct 31, 2024
@wu-sheng wu-sheng added the bug Something isn't working label Oct 31, 2024
@wu-sheng wu-sheng modified the milestones: 1.3.0, 1.2.0 Oct 31, 2024
@wu-sheng
Copy link
Member

wu-sheng commented Nov 2, 2024

@kezhenxu94 Is this CI failing caused by some out-of-date CI settings?

@wu-sheng
Copy link
Member

wu-sheng commented Nov 5, 2024

Please update the changes for 1.2.0

kezhenxu94
kezhenxu94 previously approved these changes Nov 5, 2024
View reviewed changes
wu-sheng
wu-sheng approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the changelog for all previous commits/PRs of 1.2.

FYI @kezhenxu94

@wu-sheng wu-sheng changed the title fix(plugin): fastapi testclient casue None type error in sw_fastapi p… Fix TestClient for fastapi cause the req.client None error Nov 5, 2024
@wu-sheng wu-sheng merged commit 55dc5ff into apache:master Nov 6, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

@kezhenxu94 kezhenxu94 kezhenxu94 left review comments

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@CharlieSeastar @wu-sheng @kezhenxu94